Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[port v2int 3.4] Fix signal error event in case we reconnect and we miss the first signal #14944

Conversation

NicholasCouri
Copy link
Contributor

…nal (#14939)

Description

Fix regression caused by Download snapshot with handle before throwing "Fetched snapshot is older than the received ack" by NicholasCouri · Pull Request #14225 · microsoft/FluidFramework ·
GitHub
in which, if we reconnect, we will send the SendError Logic. WIll work on adding a new test to prevent this error from happening again.

How contribute to this repo.

Guidelines for Pull Requests.

The sections included below are suggestions for what you may want to include.
Feel free to remove or alter parts of this template that do not offer value for your specific change.

Description

A concise description of the changes (bug or feature) and their impact/motivation.
If this description is short enough to be used as the title, delete this section and just use the title.

For bug fixes, also include specifics of how to reproduce it / confirm it is fixed.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Breaking Changes

If this introduces a breaking change, please describe the impact and migration path for existing applications below.
See Breaking-vs-Non-breaking-Changes for details.
If there are no breaking changes, delete this section.

Reviewer Guidance

The review process is outlined on this wiki page.

List any specific things you want to get reviewer opinions on, and anything a reviewer would need to know to review this PR effectively.
Things you might want to include:

  • Questions about how to properly make automated tests for your changes.
  • Questions about design choices you made.
  • Descriptions of how to manually test the changes (and how much of that you have done).
  • etc.

If you have any questions in this section, consider making the PR a draft until all questions have been resolved.

…nal (microsoft#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request microsoft#14225 · microsoft/FluidFramework ·
GitHub](microsoft#14225) in
which, if we reconnect, we will send the SendError Logic.
WIll work on adding a new test to prevent this error from happening
again.
@NicholasCouri NicholasCouri requested a review from a team as a code owner April 3, 2023 22:05
@github-actions github-actions bot added area: runtime Runtime related issues base: release PRs targeted against a release branch labels Apr 3, 2023
@NicholasCouri NicholasCouri changed the title Fix signal error event in case we reconnect and we miss the first sig… Fix signal error event in case we reconnect and we miss the first signal Apr 3, 2023
@NicholasCouri NicholasCouri changed the title Fix signal error event in case we reconnect and we miss the first signal [port v2int 3.4] Fix signal error event in case we reconnect and we miss the first signal Apr 3, 2023
@NicholasCouri NicholasCouri merged commit 420bcc4 into microsoft:release/v2int/3.4 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: release PRs targeted against a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants