Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[port v2int 3.4] Fix signal error event in case we reconnect and we miss the first signal #14944

Merged
merged 1 commit into from
Apr 3, 2023
Merged

[port v2int 3.4] Fix signal error event in case we reconnect and we miss the first signal #14944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/runtime/container-runtime/src/containerRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,12 +1982,13 @@ export class ContainerRuntime
clientSignalSequenceNumber: envelope.clientSignalSequenceNumber,
});
} else if (
this.consecutiveReconnects === 0 &&
envelope.clientSignalSequenceNumber ===
this._perfSignalData.trackingSignalSequenceNumber
this._perfSignalData.trackingSignalSequenceNumber
) {
// only logging for the first connection and the trackingSignalSequenceNUmber.
this.sendSignalTelemetryEvent(envelope.clientSignalSequenceNumber);
if (this.consecutiveReconnects === 0) {
this.sendSignalTelemetryEvent(envelope.clientSignalSequenceNumber);
}
this._perfSignalData.trackingSignalSequenceNumber = undefined;
}
}
Expand Down