Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download snapshot with handle before throwing "Fetched snapshot is older than the received ack" #14225

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Download snapshot with handle before throwing "Fetched snapshot is older than the received ack" #14225

merged 7 commits into from
Feb 17, 2023

Conversation

NicholasCouri
Copy link
Contributor

@NicholasCouri NicholasCouri commented Feb 16, 2023 •
edited by azure-boards bot
Loading

##Description

To address AB#3419 that was created after Incident 364621580 : [Fetched snapshot is older than the received ack], we decided to simply go ahead and retrieve the snapshot for that specific ack handle.

@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Feb 16, 2023
@msfluid-bot
Copy link
Collaborator

⯅ @fluid-example/bundle-size-tests: +568 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 432.53 KB 432.81 KB ⯅ +284 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 226.87 KB 227.15 KB ⯅ +284 Bytes
loader.js 158.56 KB 158.56 KB ■ No change
map.js 43.92 KB 43.92 KB ■ No change
matrix.js 136.09 KB 136.09 KB ■ No change
odspDriver.js 91.01 KB 91.01 KB ■ No change
odspPrefetchSnapshot.js 42.39 KB 42.39 KB ■ No change
sharedString.js 156.64 KB 156.64 KB ■ No change
Total Size 1.36 MB 1.36 MB ⯅ +568 Bytes

Baseline commit: 931542a

Generated by 🚫 dangerJS against 841f66d

@NicholasCouri NicholasCouri changed the title Download snapshotwith handle Download snapshot with handle before throwing "Fetched snapshot is older than the received ack" Feb 17, 2023
@NicholasCouri NicholasCouri marked this pull request as ready for review February 17, 2023 03:08
@NicholasCouri NicholasCouri requested a review from a team as a code owner February 17, 2023 03:08
@NicholasCouri NicholasCouri merged commit fefde97 into microsoft:main Feb 17, 2023
@NicholasCouri NicholasCouri mentioned this pull request Apr 3, 2023
Merged
NicholasCouri added a commit that referenced this pull request Apr 3, 2023
@NicholasCouri
Fix signal error event in case we reconnect and we miss the first sig…
384769c 
…nal (#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request #14225 · microsoft/FluidFramework ·
GitHub](#14225) in
which, if we reconnect, we will send the SendError Logic.
WIll work on adding a new test to prevent this error from happening
again.
NicholasCouri added a commit to NicholasCouri/FluidFramework that referenced this pull request Apr 3, 2023
@NicholasCouri
Fix signal error event in case we reconnect and we miss the first sig…
069f3fe 
…nal (microsoft#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request microsoft#14225 · microsoft/FluidFramework ·
GitHub](microsoft#14225) in
which, if we reconnect, we will send the SendError Logic.
WIll work on adding a new test to prevent this error from happening
again.
@NicholasCouri NicholasCouri mentioned this pull request Apr 3, 2023
Merged
NicholasCouri added a commit to NicholasCouri/FluidFramework that referenced this pull request Apr 3, 2023
@NicholasCouri
Fix signal error event in case we reconnect and we miss the first sig…
3442a96 
…nal (microsoft#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request microsoft#14225 · microsoft/FluidFramework ·
GitHub](microsoft#14225) in
which, if we reconnect, we will send the SendError Logic.
WIll work on adding a new test to prevent this error from happening
again.
@NicholasCouri NicholasCouri mentioned this pull request Apr 3, 2023
Merged
NicholasCouri added a commit that referenced this pull request Apr 3, 2023
@NicholasCouri
[port v2int 3.4] Fix signal error event in case we reconnect and we m…
420bcc4 
…iss the first signal (#14944)

…nal (#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request #14225 · microsoft/FluidFramework ·
GitHub](#14225) in
which, if we reconnect, we will send the SendError Logic. WIll work on
adding a new test to prevent this error from happening again.

[How contribute to this
repo](https://github.com/microsoft/FluidFramework/blob/main/CONTRIBUTING.md).

[Guidelines for Pull
Requests](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).

The sections included below are suggestions for what you may want to
include.
Feel free to remove or alter parts of this template that do not offer
value for your specific change.

## Description

> A concise description of the changes (bug or feature) and their
impact/motivation.
> If this description is short enough to be used as the title, delete
this section and just use the title.

> For bug fixes, also include specifics of how to reproduce it / confirm
it is fixed.

> If this Pull Request should close/resolve any issues when merged, use
[the special syntax for
that](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
here.

## Breaking Changes

> If this introduces a breaking change, please describe the impact and
migration path for existing applications below.
> See
[Breaking-vs-Non-breaking-Changes](https://github.com/microsoft/FluidFramework/wiki/Breaking-vs-Non-breaking-Changes)
for details.
> If there are no breaking changes, delete this section.

## Reviewer Guidance

The review process is outlined on [this wiki
page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).

> List any specific things you want to get reviewer opinions on, and
anything a reviewer would need to know to review this PR effectively.
> Things you might want to include:
>
> - Questions about how to properly make automated tests for your
changes.
> -   Questions about design choices you made.
> - Descriptions of how to manually test the changes (and how much of
that you have done).
> -   etc.
>
> If you have any questions in this section, consider making the PR a
draft until all questions have been resolved.
NicholasCouri added a commit that referenced this pull request Apr 3, 2023
@NicholasCouri
[port v2int 4.0] Fix signal error event in case we reconnect and we m…
6ca07f3 
…iss the first signal (#14943)

…nal (#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request #14225 · microsoft/FluidFramework ·
GitHub](#14225) in
which, if we reconnect, we will send the SendError Logic. WIll work on
adding a new test to prevent this error from happening again.

[How contribute to this
repo](https://github.com/microsoft/FluidFramework/blob/main/CONTRIBUTING.md).

[Guidelines for Pull
Requests](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).

The sections included below are suggestions for what you may want to
include.
Feel free to remove or alter parts of this template that do not offer
value for your specific change.

## Description

> A concise description of the changes (bug or feature) and their
impact/motivation.
> If this description is short enough to be used as the title, delete
this section and just use the title.

> For bug fixes, also include specifics of how to reproduce it / confirm
it is fixed.

> If this Pull Request should close/resolve any issues when merged, use
[the special syntax for
that](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
here.

## Breaking Changes

> If this introduces a breaking change, please describe the impact and
migration path for existing applications below.
> See
[Breaking-vs-Non-breaking-Changes](https://github.com/microsoft/FluidFramework/wiki/Breaking-vs-Non-breaking-Changes)
for details.
> If there are no breaking changes, delete this section.

## Reviewer Guidance

The review process is outlined on [this wiki
page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines).

> List any specific things you want to get reviewer opinions on, and
anything a reviewer would need to know to review this PR effectively.
> Things you might want to include:
>
> - Questions about how to properly make automated tests for your
changes.
> -   Questions about design choices you made.
> - Descriptions of how to manually test the changes (and how much of
that you have done).
> -   etc.
>
> If you have any questions in this section, consider making the PR a
draft until all questions have been resolved.
@agarwal-navin agarwal-navin mentioned this pull request Apr 25, 2023
Merged
agarwal-navin added a commit that referenced this pull request Apr 27, 2023
@agarwal-navin
Add comments and rename telemetry event for back-compat case when ref…
44074e3 
…reshing latest summary (#15269)

In `ContainerRuntime::refreshLatestSummaryAck`, when fetching snapshot
from storage, there is a back-compat case for old loader / driver where
we fetch a snapshot based on the receiving summary ack. This change adds
a comment and updates the telemetry event name for that case as it's not
clear why that additional fetch is done.

For context, the bug that led to the fix -
[AB#3419](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/3419).
PR that fixed it -
#14225
connorskees pushed a commit to connorskees/FluidFramework that referenced this pull request May 3, 2023
@agarwal-navin @connorskees
Add comments and rename telemetry event for back-compat case when ref…
eede1d0 
…reshing latest summary (microsoft#15269)

In `ContainerRuntime::refreshLatestSummaryAck`, when fetching snapshot
from storage, there is a back-compat case for old loader / driver where
we fetch a snapshot based on the receiving summary ack. This change adds
a comment and updates the telemetry event name for that case as it's not
clear why that additional fetch is done.

For context, the bug that led to the fix -
[AB#3419](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/3419).
PR that fixed it -
microsoft#14225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwal-navin agarwal-navin agarwal-navin approved these changes

Assignees
No one assigned
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasCouri @msfluid-bot @agarwal-navin