Skip to content

Commit

Permalink
Fix signal error event in case we reconnect and we miss the first sig…
Browse files Browse the repository at this point in the history
…nal (#14939)

## Description

Fix regression caused by [Download snapshot with handle before throwing
"Fetched snapshot is older than the received ack" by NicholasCouri ·
Pull Request #14225 · microsoft/FluidFramework ·
GitHub](#14225) in
which, if we reconnect, we will send the SendError Logic.
WIll work on adding a new test to prevent this error from happening
again.
  • Loading branch information
NicholasCouri authored Apr 3, 2023
1 parent 0b3afd6 commit 384769c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/runtime/container-runtime/src/containerRuntime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1945,12 +1945,13 @@ export class ContainerRuntime
clientSignalSequenceNumber: envelope.clientSignalSequenceNumber,
});
} else if (
this.consecutiveReconnects === 0 &&
envelope.clientSignalSequenceNumber ===
this._perfSignalData.trackingSignalSequenceNumber
this._perfSignalData.trackingSignalSequenceNumber
) {
// only logging for the first connection and the trackingSignalSequenceNUmber.
this.sendSignalTelemetryEvent(envelope.clientSignalSequenceNumber);
if (this.consecutiveReconnects === 0) {
this.sendSignalTelemetryEvent(envelope.clientSignalSequenceNumber);
}
this._perfSignalData.trackingSignalSequenceNumber = undefined;
}
}
Expand Down

0 comments on commit 384769c

Please sign in to comment.