Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop encrypting redactions as it isn't spec compliant #2098

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 10, 2022

Fixes element-hq/element-web#20460


Here's what your changelog entry will look like:

🐛 Bug Fixes

@t3chguy t3chguy requested a review from a team as a code owner January 10, 2022 14:23
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line fix that adds 7 tests. My kind of change.

@t3chguy t3chguy merged commit 5da562f into develop Jan 10, 2022
@t3chguy t3chguy deleted the t3chguy/fix/20460 branch January 10, 2022 17:02
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jan 17, 2022
* Don't consider alt_aliases when calculating room name ([\matrix-org#2094](matrix-org#2094)). Fixes element-hq/element-web#13887.
* Load room history if necessary when searching for MSC3089 getFileEvent() ([\matrix-org#2066](matrix-org#2066)).
* Add support for MSC3030 `/timestamp_to_event` ([\matrix-org#2072](matrix-org#2072)).
* Stop encrypting redactions as it isn't spec compliant ([\matrix-org#2098](matrix-org#2098)). Fixes element-hq/element-web#20460.
* Fix more function typings relating to key backup ([\matrix-org#2086](matrix-org#2086)).
* Fix timeline search in MSC3089 getFileEvent() ([\matrix-org#2085](matrix-org#2085)).
* Set a `deviceId` for VoIP example and use `const`/`let` ([\matrix-org#2090](matrix-org#2090)). Fixes matrix-org#2083. Contributed by @SimonBrandner.
* Fix incorrect TS return type for secret storage and key backup functions ([\matrix-org#2082](matrix-org#2082)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We shouldn't encrypt m.room.redaction events
2 participants