Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't encrypt m.room.redaction events #20460

Closed
SimonBrandner opened this issue Jan 10, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2098
Closed

We shouldn't encrypt m.room.redaction events #20460

SimonBrandner opened this issue Jan 10, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2098
Assignees
@t3chguy
Labels
A-E2EE A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@SimonBrandner
Copy link
Contributor

The js-sdk encrypts m.room.redaction but shouldn't

A fix should go somewhere here https://github.com/matrix-org/matrix-js-sdk/blob/f30be878793407b02fad1e85676d4c1644a7c30c/src/client.ts#L3739-L3738
@SimonBrandner SimonBrandner added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 10, 2022
This was referenced Jan 10, 2022
Closed
Closed
@t3chguy t3chguy self-assigned this Jan 10, 2022
@t3chguy t3chguy mentioned this issue Jan 10, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 17, 2022
@su-ex
Merge tag 'v15.4.0' into sc
5c6b029 
* Don't consider alt_aliases when calculating room name ([\matrix-org#2094](matrix-org#2094)). Fixes element-hq/element-web#13887.
* Load room history if necessary when searching for MSC3089 getFileEvent() ([\matrix-org#2066](matrix-org#2066)).
* Add support for MSC3030 `/timestamp_to_event` ([\matrix-org#2072](matrix-org#2072)).
* Stop encrypting redactions as it isn't spec compliant ([\matrix-org#2098](matrix-org#2098)). Fixes element-hq/element-web#20460.
* Fix more function typings relating to key backup ([\matrix-org#2086](matrix-org#2086)).
* Fix timeline search in MSC3089 getFileEvent() ([\matrix-org#2085](matrix-org#2085)).
* Set a `deviceId` for VoIP example and use `const`/`let` ([\matrix-org#2090](matrix-org#2090)). Fixes matrix-org#2083. Contributed by @SimonBrandner.
* Fix incorrect TS return type for secret storage and key backup functions ([\matrix-org#2082](matrix-org#2082)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-E2EE A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop encrypting redactions as it isn't spec compliant matrix-org/matrix-js-sdk
2 participants
@t3chguy @SimonBrandner