Set a deviceId for VoIP example and use const/let
#2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
germain-gg
approved these changes
Dec 23, 2021
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jan 17, 2022
* Don't consider alt_aliases when calculating room name ([\matrix-org#2094](matrix-org#2094)). Fixes element-hq/element-web#13887. * Load room history if necessary when searching for MSC3089 getFileEvent() ([\matrix-org#2066](matrix-org#2066)). * Add support for MSC3030 `/timestamp_to_event` ([\matrix-org#2072](matrix-org#2072)). * Stop encrypting redactions as it isn't spec compliant ([\matrix-org#2098](matrix-org#2098)). Fixes element-hq/element-web#20460. * Fix more function typings relating to key backup ([\matrix-org#2086](matrix-org#2086)). * Fix timeline search in MSC3089 getFileEvent() ([\matrix-org#2085](matrix-org#2085)). * Set a `deviceId` for VoIP example and use `const`/`let` ([\matrix-org#2090](matrix-org#2090)). Fixes matrix-org#2083. Contributed by @SimonBrandner. * Fix incorrect TS return type for secret storage and key backup functions ([\matrix-org#2082](matrix-org#2082)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2083
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
deviceIdfor VoIP example and useconst/let(#2090). Fixes VOIP connection not established in demo code #2083. Contributed by @SimonBrandner.