Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include guards to all headers #2042

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add include guards to all headers #2042

merged 1 commit into from
Sep 15, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 15, 2023

Also add a CI job to check for them.

@Riolku Riolku marked this pull request as draft September 15, 2023 18:41
@Riolku Riolku marked this pull request as ready for review September 15, 2023 18:42
@Riolku Riolku force-pushed the fix-pragmas branch 2 times, most recently from 7126002 to 5ce44bc Compare September 15, 2023 18:44
@Riolku Riolku marked this pull request as draft September 15, 2023 18:46
Also add a CI job to check for them.
@Riolku Riolku marked this pull request as ready for review September 15, 2023 19:02
@Riolku
Copy link
Contributor Author

Riolku commented Sep 15, 2023

Ref #2036 .

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (d8a5ca4) 90.14% compared to head (5111406) 90.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
- Coverage   90.14%   90.14%   -0.01%     
==========================================
  Files         938      937       -1     
  Lines       33364    33363       -1     
==========================================
- Hits        30075    30074       -1     
  Misses       3289     3289              
Files Changed Coverage Δ
.../binder/rewriter/with_clause_projection_rewriter.h 100.00% <ø> (ø)
src/include/optimizer/factorization_rewriter.h 100.00% <ø> (ø)
src/include/optimizer/logical_operator_collector.h 91.66% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku merged commit 5111406 into master Sep 15, 2023
11 checks passed
@Riolku Riolku deleted the fix-pragmas branch September 15, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants