Add include guards to all headers

.github/workflows/ci-workflow.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   gcc-build-test:
     name: gcc build & test
-    needs: [clang-formatting-check]
+    needs: [clang-formatting-check, header-include-guard-check]
     runs-on: kuzu-self-hosted-testing
     steps:
       - uses: actions/checkout@v3
@@ -130,7 +130,7 @@ jobs:
 
   clang-build-test:
     name: clang build & test
-    needs: [clang-formatting-check]
+    needs: [clang-formatting-check, header-include-guard-check]
     runs-on: kuzu-self-hosted-testing
     steps:
       - uses: actions/checkout@v3
@@ -161,7 +161,7 @@ jobs:
 
   msvc-build-test:
     name: msvc build & test
-    needs: [clang-formatting-check]
+    needs: [clang-formatting-check, header-include-guard-check]
     runs-on: self-hosted-windows
     env:
       # Shorten build path as much as possible
@@ -195,6 +195,15 @@ jobs:
           call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
           make javatest NUM_THREADS=18
 
+  header-include-guard-check:
+    name: header include guard check
+    runs-on: kuzu-self-hosted-testing
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Check headers for include guards
+        run: ./scripts/check-headers.sh src/include
+
   clang-formatting-check:
     name: clang-format check
     runs-on: kuzu-self-hosted-testing

scripts/check-headers.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+# -L returns 0 if there are any matches, which means any file containing the
+# pragma will cause this to give a exit status of 1. It's a bit hacky, but we
+# just pipe this to grep again, which exits with 0 if there are any lines and 1
+# otherwise.
+! grep -rL "^#pragma once" $1 | grep ""

src/include/binder/bound_statement_rewriter.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "bound_statement.h"
 
 namespace kuzu {

src/include/binder/rewriter/with_clause_projection_rewriter.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "binder/bound_statement_visitor.h"
 
 namespace kuzu {

src/include/common/types/value/nested.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include <cstdint>
 
 #include "common/api.h"

src/include/common/types/value/recursive_rel.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "common/api.h"
 
 namespace kuzu {

src/include/common/types/value/rel.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include <cstdint>
 #include <memory>
 #include <string>

src/include/expression_evaluator/expression_evaluator_utils.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "binder/expression/expression.h"
 #include "expression_evaluator.h"
 

src/include/main/kuzu_fwd.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include <cstdint>
 
 namespace kuzu {

src/include/optimizer/factorization_rewriter.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "logical_operator_visitor.h"
 #include "planner/logical_plan/logical_plan.h"
 

src/include/optimizer/logical_operator_collector.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "logical_operator_visitor.h"
 
 namespace kuzu {

src/include/planner/join_order/cost_model.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "planner/logical_plan/logical_plan.h"
 
 namespace kuzu {

src/include/storage/store/struct_node_column.h

@@ -1,3 +1,5 @@
+#pragma once
+
 #include "node_column.h"
 #include "storage/store/table_statistics.h"