Skip to content

Commit

Permalink
Add include guards to all headers
Browse files Browse the repository at this point in the history
Also add a CI job to check for them.
  • Loading branch information
Riolku committed Sep 15, 2023
1 parent d8a5ca4 commit 5ce44bc
Show file tree
Hide file tree
Showing 13 changed files with 35 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,18 @@ jobs:
call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
make javatest NUM_THREADS=18
header-include-guard-check:
name: header include guard check
runs-on: kuzu-self-hosted-testing
steps:
- uses: actions/checkout@v3

- name: Check headers for include guards
run: ./scripts/check-headers.sh -q src/include

clang-formatting-check:
name: clang-format check
needs: [header-include-guard-check]
runs-on: kuzu-self-hosted-testing
steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 3 additions & 0 deletions scripts/check-headers.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/sh

! grep -rL "^#pragma once" $@
2 changes: 2 additions & 0 deletions src/include/binder/bound_statement_rewriter.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "bound_statement.h"

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/binder/rewriter/with_clause_projection_rewriter.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "binder/bound_statement_visitor.h"

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/common/types/value/nested.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include <cstdint>

#include "common/api.h"
Expand Down
2 changes: 2 additions & 0 deletions src/include/common/types/value/recursive_rel.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "common/api.h"

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/common/types/value/rel.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include <cstdint>
#include <memory>
#include <string>
Expand Down
2 changes: 2 additions & 0 deletions src/include/expression_evaluator/expression_evaluator_utils.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "binder/expression/expression.h"
#include "expression_evaluator.h"

Expand Down
2 changes: 2 additions & 0 deletions src/include/main/kuzu_fwd.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include <cstdint>

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/optimizer/factorization_rewriter.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "logical_operator_visitor.h"
#include "planner/logical_plan/logical_plan.h"

Expand Down
2 changes: 2 additions & 0 deletions src/include/optimizer/logical_operator_collector.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "logical_operator_visitor.h"

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/planner/join_order/cost_model.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "planner/logical_plan/logical_plan.h"

namespace kuzu {
Expand Down
2 changes: 2 additions & 0 deletions src/include/storage/store/struct_node_column.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#pragma once

#include "node_column.h"
#include "storage/store/table_statistics.h"

Expand Down

0 comments on commit 5ce44bc

Please sign in to comment.