Fix cmake configuration

[yixinglu]

COMMAND_ERROR_IS_FATAL was introduced in cmake 3.19, see here for details. This is inconsistent with the cmake minimum required version 3.11.

I have read and agree to the terms under CLA.md.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (134ced4) 90.03% compared to head (8482371) 90.00%.
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
- Coverage   90.03%   90.00%   -0.04%     
==========================================
  Files         909      909              
  Lines       32928    32998      +70     
==========================================
+ Hits        29646    29699      +53     
- Misses       3282     3299      +17     

see 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benjaminwinger]

Removing COMMAND_ERROR_IS_FATAL looks good to me (my mistake for adding it in the first place without checking the version requirements).

For CMAKE_EXPORT_COMPILE_COMMANDS, I'm not convinced it's something that needs to be included in CMakeLists.txt, though I'm not strongly against it either.
E.g. you can set it as an environment variable instead if you need it, or just set it manually on your build directory (see here).

[yixinglu]

@benjaminwinger I know that the CMAKE_EXPORT_COMPILE_COMMANDS option can be modified by environment variable or cmake argument, because the corresponding compile_commands.json file is always generated in the build directory, and the build directory is ignored, so it is no problem to turn on it by default. However, I have removed this change, please review this PR again. Thanks.

[benjaminwinger]

Okay, sounds good.

Also, since this is your first time contributing to this repository, you need to agree to the contributor license agreement (see here) (I guess it doesn't actually say that you have to do so explicitly, but stating it explicitly in your PR lets us know that you've read and understand that part).

[mewim]

@yixinglu Could you please take a look at our CLA at https://github.com/kuzudb/kuzu/blob/master/CLA.md and add a sentence "I have read and agree to the terms under CLA.md." to your PR description if it looks good to you? Once you agree with the CLA we can get this PR merged. Thank you.

[yixinglu]

@yixinglu Could you please take a look at our CLA at https://github.com/kuzudb/kuzu/blob/master/CLA.md and add a sentence "I have read and agree to the terms under CLA.md." to your PR description if it looks good to you? Once you agree with the CLA we can get this PR merged. Thank you.

done