Fix cmake configuration (#2022)

* Fix cmake configuration * Delete the CMAKE_EXPORT_COMPILE_COMMANDS option
kuzudb · Sep 13, 2023 · bd69420 · bd69420
1 parent 32f38fb
commit bd69420
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,12 +4,15 @@
 bazel-*
 .clwb
 .cache
+.ccls-cache
 .bazelrc
 test/test_files/test_list
 
 test_temp/
 build/
 
+compile_commands.json
+
 ### Python
 # Byte-compiled / optimized / DLL files
 __pycache__/

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -172,9 +172,15 @@ else()
             -DENABLE_UBSAN=${ENABLE_UBSAN}
             -DFORCE_COLORED_OUTPUT=${FORCE_COLORED_OUTPUT}
             WORKING_DIRECTORY ${ARROW_BUILD_DIR}
-            COMMAND_ERROR_IS_FATAL ANY)
+            RESULT_VARIABLE ARROW_CONFIGURE_RESULT)
+        if (ARROW_CONFIGURE_RESULT)
+            message(FATAL_ERROR "Failed to configure arrow")
+        endif()
         execute_process(COMMAND ${CMAKE_COMMAND} --build ${ARROW_BUILD_DIR} --config ${CMAKE_BUILD_TYPE}
-            COMMAND_ERROR_IS_FATAL ANY)
+            RESULT_VARIABLE ARROW_BUILD_RESULT)
+        if (ARROW_BUILD_RESULT)
+            message(FATAL_ERROR "Failed to build arrow")
+        endif()
     else()
         message(STATUS "Using arrow at path ${ARROW_INSTALL}")
     endif()