Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake configuration #2022

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix cmake configuration #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b28d14d
Fix cmake configuration
yixinglu Sep 12, 2023
8482371
Delete the CMAKE_EXPORT_COMPILE_COMMANDS option
yixinglu Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
bazel-*
.clwb
.cache
.ccls-cache
.bazelrc
test/test_files/test_list

test_temp/
build/

compile_commands.json

### Python
# Byte-compiled / optimized / DLL files
__pycache__/
Expand Down
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,15 @@ else()
-DENABLE_UBSAN=${ENABLE_UBSAN}
-DFORCE_COLORED_OUTPUT=${FORCE_COLORED_OUTPUT}
WORKING_DIRECTORY ${ARROW_BUILD_DIR}
COMMAND_ERROR_IS_FATAL ANY)
RESULT_VARIABLE ARROW_CONFIGURE_RESULT)
if (ARROW_CONFIGURE_RESULT)
message(FATAL_ERROR "Failed to configure arrow")
endif()
execute_process(COMMAND ${CMAKE_COMMAND} --build ${ARROW_BUILD_DIR} --config ${CMAKE_BUILD_TYPE}
COMMAND_ERROR_IS_FATAL ANY)
RESULT_VARIABLE ARROW_BUILD_RESULT)
if (ARROW_BUILD_RESULT)
message(FATAL_ERROR "Failed to build arrow")
endif()
else()
message(STATUS "Using arrow at path ${ARROW_INSTALL}")
endif()
Expand Down