Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adowair as owner, reviewer for Arabic content #45815

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add adowair as owner, reviewer for Arabic content #45815

merged 1 commit into from
Apr 17, 2024

Conversation

adowair
Copy link

@adowair adowair commented Apr 10, 2024

This commit will add @adowair as an owner (approver) and reviewer for Arabic content on the website. This is based on the discussion here #44862 (comment).

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2024
@adowair
Copy link
Author

adowair commented Apr 10, 2024

/assign @a-mccarthy @sftim

@sftim
Copy link
Contributor

sftim commented Apr 10, 2024

/unassign @sftim

I'm happy for anyone to review this.

@mboukhalfa
Copy link
Member

/approve

@a-mccarthy
Copy link
Contributor

@adowair this PR needs a rebase bc this pr #45793 was just merged.

@adowair
Add adowair as reviewer, owner of Arabic content
36aee3f 
This commit will add adowair as an owner (approver) and reviewer
for Arabic content on the website.

Signed-off-by: Ali Dowair <adowair@umich.edu>
@adowair adowair force-pushed the dev-1.29-ar.1-adowair-owner branch from 2028af2 to 36aee3f Compare April 10, 2024 20:47
@adowair
Copy link
Author

adowair commented Apr 10, 2024

Thanks

@adowair this PR needs a rebase bc this pr #45793 was just merged.

Thanks @a-mccarthy, I've rebased here: 36aee3f

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 10, 2024
@mboukhalfa
Copy link
Member

/approve

@mboukhalfa
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74944247a37c91799f4d4e802feba8953457d404

@adowair
Copy link
Author

adowair commented Apr 16, 2024

/assign @katcosgrove

@sftim
Copy link
Contributor

sftim commented Apr 16, 2024

/unassign @katcosgrove

For this one, Prow doesn't know it, but an existing Arabic approver should approve the PR. @mboukhalfa is an Arabic approver, so:
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e54823 into kubernetes:dev-1.29-ar.1 Apr 17, 2024
2 checks passed
@adowair adowair deleted the dev-1.29-ar.1-adowair-owner branch April 17, 2024 21:17
@adowair adowair mentioned this pull request Apr 28, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboukhalfa mboukhalfa mboukhalfa approved these changes

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@mboukhalfa mboukhalfa

@a-mccarthy a-mccarthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adowair @sftim @mboukhalfa @a-mccarthy @k8s-ci-robot @katcosgrove