[ar] Add and localize i18n strings to Arabic #44862

adowair · 2024-01-23T18:54:16Z

This PR will add a new file i18n/ar/ar.toml, containing a copy
of the english localization strings, translated to Arabic. This
commit contributes to Step 8 of the effort to localize the Docs
website to Arabic (#44682):

Open a PR to configure a localization environment
Note: base and target branches of the PR should be the dev branch of AR.
[TODO] Add and localize site strings in i18n
https://kubernetes.io/docs/contribute/localization/#site-strings-in-i18n

This PR is based on @mboukhalfa's great work in #44902.

sftim · 2024-01-26T01:21:46Z

/language ar

sftim

Some early feedback.

data/i18n/ar/OWNERS

data/i18n/ar/ar.toml

mboukhalfa

great work please use كوبرناتيز instead of كوبرناتيز so we can use k8s as ك8ز

data/i18n/ar/ar.toml

seifrajhi · 2024-02-22T23:15:21Z

data/i18n/ar/ar.toml

+other = "linux"
+
+[release_binary_os_windows]
+other = "windows"


ويندوز

ويندوز?

or: comment it out, for now.

Thank you folks, I've commented these out here: 2dff0d4.

seifrajhi · 2024-02-22T23:15:35Z

data/i18n/ar/ar.toml

+other = "darwin"
+
+[release_binary_os_linux]
+other = "linux"


لينوكس

I'd use لينكس

or: comment it out, for now.

Thank you folks, I've commented these out here: 2dff0d4.

seifrajhi · 2024-02-22T23:19:36Z

data/i18n/ar/ar.toml

+other = "checksum"
+
+[release_binary_copy_link_signature]
+other = "signature"


إمضاء

Thanks @seifrajhi, I've commented these out for now heeding @sftim's suggestion. What do you think?

data/i18n/ar/ar.toml

seifrajhi · 2024-02-22T23:21:13Z

data/i18n/ar/ar.toml

+other = "ساهم"
+
+[main_copyright_notice]
+other = """مؤسسة لينَكس &reg;. جميع الحقوق محفوظة. لدى مؤسسة لينكس علامات تجارية مسجلة وتستخدم العلامات التجارية .للحصول على قائمة العلامات التجارية لمؤسسة لينكس يرجى الاطلاع على <a href="https://www.linuxfoundation.org/trademark-usage" class="light-text">صفحة استخدام العلامات التجارية</a>"""


لينوكس

adowair · 2024-02-23T10:22:27Z

Thank you for the review @seifrajhi! Since the standards (#45082) for localizing "kubernetes", "linux", "windows" have not been merged yet, I'd like to put forward the desire (if everything else looks good), to merge this PR ASAP, and improve incrementally, rather than wait for the standards to be agreed on. I commit to doing the due diligence to change all files as the standards are set.

Here are some more thoughts on that from #45082.

@mboukhalfa what do you think?

sftim

Thanks

Would you like to squash this down to 1 commit?

sftim · 2024-02-23T10:33:30Z

data/i18n/ar/ar.toml

+other = "darwin"
+
+[release_binary_os_linux]
+other = "linux"


I'd use لينكس

sftim · 2024-02-23T10:34:04Z

data/i18n/ar/ar.toml

+other = "linux"
+
+[release_binary_os_windows]
+other = "windows"


ويندوز?

data/i18n/ar/ar.toml

sftim · 2024-02-23T10:38:01Z

data/i18n/ar/ar.toml

+other = "ملخص القضية"
+
+[cve_table]
+other = "القائمة الرسمية للCVE الخاصة بكوبرنيتيز"


I don't recommend resolving things if you're unsure whether the commenter would see the feedback as addressed.

sftim · 2024-02-23T10:38:10Z

data/i18n/ar/ar.toml

+other = "CVE ID"
+
+[cve_issue_url]
+other = "رابط القضية للCVE"


I don't recommend resolving things if you're unsure whether the commenter would see the feedback as addressed.

sftim · 2024-02-23T10:38:33Z

data/i18n/ar/ar.toml

+other = "و"
+
+[cve_id]
+other = "CVE ID"


I don't recommend resolving things if you're unsure whether the commenter would see the feedback as addressed.

Also, I would localize “ID”.

data/i18n/ar/ar.toml

sftim · 2024-02-23T11:00:26Z

data/i18n/ar/ar.toml

+# See https://gohugo.io/functions/format/#gos-layout-string
+# Use a suitable format for your locale
+[release_date_format]
+other = "2006-01-02"


Is this date format OK?

Thanks for pointing that out @sftim, I've updated this here: ea6c812. I could not tell whether Eastern Arabic numerals are supported, but this I hope will be acceptable, per the team's synchro conversation.

adowair · 2024-02-23T12:04:33Z

Would you like to squash this down to 1 commit?

Thanks for the review @sftim, and yes please, let's squash this one 😄. Is that something the approved would do?

mboukhalfa · 2024-02-23T13:36:14Z

LGTM for arabic
Thanks @adowair

mboukhalfa · 2024-02-23T13:48:38Z

/lgtm

k8s-ci-robot · 2024-02-23T13:48:44Z

LGTM label has been added.

Git tree hash: 8896220491cccafd2085ad034766fa1b2ee434d3

sftim · 2024-03-09T11:50:55Z

How's this work going? Would anyone who is working on Arabic like to use the /approve command to mark approval?
@adowair please squash this to 1 commit, keeping the exact same final set of files

This commit will add a new file ar.toml, as well as an appropriate symbolic link, containing Arabic versions for almost all localization strings used in the website. String which have not been localized to Arabic are kept in the file and commented out. Copy i18n/en/en.toml to /ar/ Fix whitespace from copy [WIP] Add and localize site strings to Arabic This commit will add a new file i18n/ar/ar.toml, containing a copy of the english localizationn strings, translated to Arabic. This commit contributes to Step 8 of the effort to localize the Docs website to Arabic. [WIP] Add more string localizations This partial commit will add some more localizations of strings. Some of these are based on Mohammed Boukhalfa's earlier work. Delete OWNERS file This commit will remove the OWNERS file from this PR, in response to a review comment. Add symbolic link for ar.toml This commit will add a symbolic link for data/i18n/ar/ar.toml to i18n/ar.toml. [WIP] Add more strings and address reviews Co-authored-by: Mohammed BOUKHALFA <mohammedboukhalfa@yandex.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Keep English translation for social links This commit will keep both English and transliterated forms of social links, as they are instantly recognizable in English. Signed-off-by: Ali Dowair <adowair@umich.edu> [WIP] Add more strings, fix typos, address review Co-authored-byL Mohammed BOUKHALFA <mohammedboukhalfa@yandex.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Respond to review comment This commit will remove an extraneous conjunctive. Co-authored-by: Mohammed BOUKHALFA <mohammed.boukhalfa@est.tech> Complete string translations This commit will complete string translations and fix some typos. There are some strings which, in my opinion, should not be translated at all, such as "alpha", "beta". I left these untranslated but did not remove them, to show that not translating them is intentional. Change translation of KubeWeekly "Subscribe" Based on review comments, this commit will change the relevant translation to be shorter, to ensure that it fits inside the button. Co-authored-by: Mohammed BOUKHALFA <mohammedboukhalfa@yandex.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Address review comments This commit will address some review comments Co-authored-by: Mohammeed BOUKHALFA <mohammedboukhalfa@yandex.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Apply suggestions from code review This commit will remove English language tags from some href links Co-authored-by: Tim Bannister <tim@scalefactory.com> Comment out unresolved localizations This commit will comment out localization strings which have not yet been translated to due to the ongoing process of setting localization standards. Co-authored-by: Tim Bannister <tim+github@scalefactory.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Localize "ID" in "CVE ID" This commit will localize "ID" in the term "CVE ID" Co-authored-by: TIm Bannister <tim+github@scalefactory.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Change translation of "Kubernetes" to "كوبيرنيتيس" This commit will change the translation of "Kubernetes" in accordance with the agreed-upon standard in kubernetes#45082 and kubernetes#45078. Co-authored-by: Saifeddine Rajhi <rajhisaif@gmail.com> Co-authored-by: Mohammed BOUKHALFA <mohammedboukhalfa@yandex.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Comment out OS name translations This commit will comment out OS name translations addressing a review comment. Co-authored-by: Tim Bannister <tim+github@scalefactory.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Remove English href tag Co-authored-by: Tim Bannister <tim@scalefactory.com> Translate "CLI" This commit will translate CLI as "واجهة سطر الأوامر" which corresponds to the current Wikipedia translation, in accordance with a review comment. Co-authored-by: Saifeddine Rajhi <rajhisaif@gmail.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Update date format localization string This commit will update the date format string to conform to what is customary in Arabic (DD-MM-YYYY). As far as I can tell, only Arabic numerals are supported, so I have decided to keep that (rather than Eastern Arabic numerals ١١-٢٢-٣٣٣٣). Co-authored-by: Tim Bannister <tim+github@scalefactory.com> Signed-off-by: Ali Dowair <adowair@umich.edu> Fix a grammer nit and "Kubernetes" translation Signed-off-by: Ali Dowair <adowair@umich.edu>

adowair · 2024-03-12T20:42:17Z

@sftim understood, I've squashed everything into b6fec9d
@mboukhalfa I believe you are the only member of the team with permission to /approve—will you please use it to kickoff the merge? Thanks!

sftim · 2024-03-12T20:59:02Z

@mboukhalfa I believe you are the only member of the team with permission to /approve—will you please us it to kickoff the merge? Thanks!

Localization teams should always have two or more approvers. Who are the proposed approvers for Arabic? (the people who will formally be the approvers once the localization is launched)

mboukhalfa · 2024-03-13T08:56:08Z

/approve

mboukhalfa · 2024-03-13T08:57:58Z

@sftim understood, I've squashed everything into b6fec9d

@mboukhalfa I believe you are the only member of the team with permission to /approve—will you please us it to kickoff the merge? Thanks!

/lgtm
for now is the only thing I can do I do not have approve permission

k8s-ci-robot · 2024-03-13T08:58:04Z

LGTM label has been added.

Git tree hash: 128d23a72865230a0c5de46e22cabacafbf34be6

sftim · 2024-03-13T09:14:05Z

Here's what I'm / we're looking for:

(at least) one person to record their approval, using /approve
consensus on who the group of approvers for Arabic will be, eventually

sftim · 2024-03-13T09:16:17Z

Who are the proposed approvers for Arabic? (the people who will formally be the approvers once the localization is launched)

We've got an approval, provided there's that consensus and @mboukhalfa you're in the set of approvers.

adowair · 2024-03-13T17:46:53Z

consensus on who the group of approvers for Arabic will be, eventually

@sftim Thank you for clarifying that. From our (just now) team meeting (minutes):

Volunteer reviewers:

Volunteer approvers:

@mboukhalfa (already org member)
@adowair (not org member yet)
@seifrajhi (if needed, not org member yet)

sftim · 2024-03-13T18:51:46Z

Great

On behalf of Arabic localization:
/approve

k8s-ci-robot · 2024-03-13T18:53:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adowair · 2024-03-13T21:40:57Z

Thank you for supporting us @sftim!! We'll hopefully be self-sustaining soon

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2024

k8s-ci-robot requested review from dipesh-rawat and tengqm January 23, 2024 18:54

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 23, 2024

adowair mentioned this pull request Jan 25, 2024

Create basic structure and translate home for Arabic #44902

Closed

k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Jan 26, 2024

sftim reviewed Jan 26, 2024

View reviewed changes

data/i18n/ar/OWNERS Outdated Show resolved Hide resolved

data/i18n/ar/ar.toml Show resolved Hide resolved

seokho-son mentioned this pull request Jan 31, 2024

Localize Kubernetes website into Arabic #44682

Open

16 tasks

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 1, 2024

adowair force-pushed the dev-1.29-ar.1-data/i18n branch from 2cf880f to 8eef980 Compare February 1, 2024 20:36

k8s-ci-robot removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 1, 2024

adowair changed the title ~~Add and localize i18n strings to Arabic~~ [ar] Add and localize i18n strings to Arabic Feb 6, 2024

mboukhalfa reviewed Feb 6, 2024

View reviewed changes

mboukhalfa reviewed Feb 7, 2024

View reviewed changes

data/i18n/ar/ar.toml Outdated Show resolved Hide resolved

adowair marked this pull request as ready for review February 10, 2024 11:16

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2024

k8s-ci-robot requested review from divya-mohan0209 and windsonsea February 10, 2024 11:16

seifrajhi reviewed Feb 22, 2024

View reviewed changes

sftim reviewed Feb 23, 2024

View reviewed changes

data/i18n/ar/ar.toml Outdated Show resolved Hide resolved

sftim reviewed Feb 23, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 23, 2024

adowair force-pushed the dev-1.29-ar.1-data/i18n branch from 3c7a511 to c8f104b Compare February 23, 2024 11:40

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 23, 2024

k8s-ci-robot assigned mboukhalfa Feb 23, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024

adowair force-pushed the dev-1.29-ar.1-data/i18n branch from e42b698 to b6fec9d Compare March 12, 2024 20:41

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024

k8s-ci-robot requested a review from mboukhalfa March 12, 2024 20:41

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024

k8s-ci-robot merged commit 071b4a1 into kubernetes:dev-1.29-ar.1 Mar 13, 2024
2 checks passed

mboukhalfa mentioned this pull request Mar 13, 2024

[ar] Add mboukhalfa as owner for arabic content #45541

Merged

adowair mentioned this pull request Mar 16, 2024

REQUEST: New membership for adowair kubernetes/org#4831

Closed

9 tasks

adowair mentioned this pull request Apr 10, 2024

Add adowair as owner, reviewer for Arabic content #45815

Merged

seifrajhi mentioned this pull request Apr 24, 2024

Add seifrajhi as approver and reviewer for Arabic localisations docs #46009

Closed

[ar] Add and localize i18n strings to Arabic #44862

[ar] Add and localize i18n strings to Arabic #44862

Conversation

adowair commented Jan 23, 2024 • edited Loading

sftim commented Jan 26, 2024

sftim left a comment

Choose a reason for hiding this comment

mboukhalfa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adowair commented Feb 23, 2024 • edited Loading

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adowair commented Feb 23, 2024 • edited Loading

mboukhalfa commented Feb 23, 2024

mboukhalfa commented Feb 23, 2024

k8s-ci-robot commented Feb 23, 2024

sftim commented Mar 9, 2024

adowair commented Mar 12, 2024 • edited Loading

sftim commented Mar 12, 2024

mboukhalfa commented Mar 13, 2024

mboukhalfa commented Mar 13, 2024

k8s-ci-robot commented Mar 13, 2024

sftim commented Mar 13, 2024 • edited Loading

sftim commented Mar 13, 2024

adowair commented Mar 13, 2024 • edited Loading

sftim commented Mar 13, 2024

k8s-ci-robot commented Mar 13, 2024

adowair commented Mar 13, 2024 • edited Loading

adowair commented Jan 23, 2024 •

edited

Loading

adowair commented Feb 23, 2024 •

edited

Loading

adowair commented Feb 23, 2024 •

edited

Loading

adowair commented Mar 12, 2024 •

edited

Loading

sftim commented Mar 13, 2024 •

edited

Loading

adowair commented Mar 13, 2024 •

edited

Loading

adowair commented Mar 13, 2024 •

edited

Loading