Changes to deprecate powervs-provider-id-fmt flag #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/ibmcloud
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/L
mkumatag
requested changes
Jan 16, 2023
| @@ -0,0 +1,170 @@ | |||
| # CLI tool for Cluster API Provider IBM Cloud | |||
There was a problem hiding this comment.
Why this doc included in this PR?
There was a problem hiding this comment.
By mistake removed it.
| @@ -177,7 +177,7 @@ func initFlags(fs *pflag.FlagSet) { | |||
| &options.ProviderIDFormat, | |||
| "provider-id-fmt", | |||
| string(options.ProviderIDFormatV1), | |||
| "ProviderID format is used set the Provider ID format for Machine (Currently for VPC machines only)", | |||
| "ProviderID format is used set the Provider ID format for Machine", | |||
| ) | |||
There was a problem hiding this comment.
Lets add following code to deprecate it
fs.MarkDeprecated("powervs-provider-id-fmt", "please use provider-id-fmt flag")There was a problem hiding this comment.
Updated it accordingly.
main.go
Outdated
| @@ -191,17 +191,17 @@ func initFlags(fs *pflag.FlagSet) { | |||
| func validateFlags() error { | |||
| switch options.ProviderIDFormatType(options.PowerVSProviderIDFormat) { | |||
| case options.PowerVSProviderIDFormatV1: | |||
| setupLog.Info("Using v1 version of Power VS ProviderID format") | |||
| setupLog.Info("Power VS ProviderID format is set to v1 version, Note: its deprecated use provider-id-fmt to provider id format") | |||
There was a problem hiding this comment.
with the above MarkDeprecated call, you may not need this explicit message anymore
Karthik-K-N
force-pushed
the
provider_id_changes
branch
from
acc871c
to
84871a3
Compare
k8s-ci-robot
added
size/S
Karthik-K-N
force-pushed
the
provider_id_changes
branch
from
84871a3
to
5e4588b
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Karthik-K-N
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently for Power VS clusters provider id format is set via powervs-provider-id-fmt flag, With recent merge of VPC CCM support PR we have introduced flag
provider-id-fmt, same can be used to set provider id format for Power VS as well.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1024
Special notes for your reviewer:
/area provider/ibmcloud
Release note: