Add external cloud provider support for VPC #1015

Karthik-K-N · 2023-01-04T12:46:03Z

What this PR does / why we need it:

This PR adds the support to use external cloud controller for VPC cluster, Major changes included are

Made changes to update the provider id format for VPC machines as per the ibmcloud ccm
Added command line flag named provider-id-format to allow user to select the provider id format. For ccm support it should be set to v2.
Added template to create cluster with external cloud controller.
Added necessary documentation to configure external cloud controller.

With this support now users will be able to create a service of type LoadBalancer in workload clusters.

Previous PR to add external cloud provider support for Power VS workload cluster: #614

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #990

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

netlify · 2023-01-04T12:46:07Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`a4fffc2`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/63be3fb05092370009b49d60
😎 Deploy Preview	https://deploy-preview-1015--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pkg/cloud/services/vpc/vpc.go

cloud/scope/machine.go

Karthik-K-N · 2023-01-05T09:40:43Z

Tested the CCM integration as follows

Created a deployment

apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
spec:
  selector:
    matchLabels:
      app: nginx
  replicas: 2
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
        - name: nginx
          image: nginx:1.14.2
          ports:
            - containerPort: 80

Created a LoadBalancer Service

apiVersion: v1
kind: Service
metadata:
  name: test-svc
spec:
  type: LoadBalancer
  ports:
    - name: http
      port: 80
      targetPort: 80
  selector:
    app: nginx
  externalTrafficPolicy: Cluster

Loadbalancer got created in IBM Cloud

Health status of Loadbalancer

Tried accessing the service via loadbalancer URL

main.go

Prajyot-Parab · 2023-01-10T16:02:11Z

/lgtm

main.go

mkumatag · 2023-01-10T13:02:11Z

templates/cluster-template-powervs-cloud-provider.yaml

-                - name: VPCCTL_CLOUD_CONFIG
-                  value: /etc/cloud/ibmpowervs.conf
-                - name: VPCCTL_PUBLIC_ENDPOINT


don't we need these params anymore? if yes - why?

VPCCTL_CLOUD_CONFIG has been removed as a part of refactoring IBM Cloud provider repo.

VPCCTL_PUBLIC_ENDPOINT has been renamed as ENABLE_VPC_PUBLIC_ENDPOINT

main.go

mkumatag · 2023-01-10T13:10:40Z

main.go

+	case options.ProviderIDFormatV2:
+		setupLog.Info("Using v2 version of ProviderID format")
+	default:
+		errStr := fmt.Errorf("invalid value for flag provider-id-fmt: %s, Supported values: %s, %s ", options.PowerVSProviderIDFormat, options.ProviderIDFormatV1, options.ProviderIDFormatV2)


why options.PowerVSProviderIDFormat here?

main.go

mkumatag · 2023-01-11T03:25:04Z

docs/book/src/developer/tilt.md

@@ -10,7 +10,7 @@ This document describes how to use [kind](https://kind.sigs.k8s.io) and [Tilt](h
 2. [kind](https://kind.sigs.k8s.io) v0.9 or newer (other clusters can be
   used if `preload_images_for_kind` is set to false)
 3. [kustomize](https://kubectl.docs.kubernetes.io/installation/kustomize/)
-4. [Tilt](https://docs.tilt.dev/install.html) v0.22.2 or newer
+4. [Tilt](https://docs.tilt.dev/install.html) v0.30.8 or newer


any reason for bumping the minimum tilt version required?

Its the requirement from cluster api: https://github.com/Karthik-K-N/cluster-api/blob/3aae0e86340a519feffc3e398c2fa81795fd73c9/Tiltfile#L19

mkumatag · 2023-01-11T03:29:25Z

docs/book/src/getting-started.md

-    ```
-   > Note: To deploy workload cluster with [Power VS clusterclass-template](/topics/powervs/clusterclass-cluster.html). Set the `POWERVS_PROVIDER_ID_FORMAT` environmental variable.
-     Currently, both [ClusterClass](https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-class/index.html) and [ClusterResourceset](https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set.html) are experimental feature so we need to enable the feature gate by setting `EXP_CLUSTER_RESOURCE_SET`, `CLUSTER_TOPOLOGY` environmental variables.
+    > Note: To deploy VPC workload cluster with [IBM cloud controller manager](/topics/vpc/load-balancer.html) which is currently in experimental stage. Set the `PROVIDER_ID_FORMAT` environmental variable.


content wise is good but this section contains lots of notes section and became tough to read, lets refactor this page in a separate issue.

pkg/cloud/services/utils/accounts.go

mkumatag

/lgtm

k8s-ci-robot · 2023-01-12T03:40:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jan 4, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2023

k8s-ci-robot requested review from gyliu513 and mkumatag January 4, 2023 12:46

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 4, 2023

Karthik-K-N commented Jan 4, 2023

View reviewed changes

pkg/cloud/services/vpc/vpc.go Outdated Show resolved Hide resolved

mkumatag reviewed Jan 5, 2023

View reviewed changes

cloud/scope/machine.go Outdated Show resolved Hide resolved

mkumatag reviewed Jan 5, 2023

View reviewed changes

cloud/scope/machine.go Show resolved Hide resolved

Karthik-K-N force-pushed the vpc_ccm_support branch from 5cdd423 to 5fe2e75 Compare January 5, 2023 09:37

Karthik-K-N changed the title ~~[WIP] Add external cloud provider support for VPC~~ Add external cloud provider support for VPC Jan 5, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023

Karthik-K-N force-pushed the vpc_ccm_support branch from 5fe2e75 to 02e3f46 Compare January 6, 2023 09:31

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 6, 2023

Karthik-K-N force-pushed the vpc_ccm_support branch from 02e3f46 to a3ba727 Compare January 10, 2023 06:52

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023

Karthik-K-N force-pushed the vpc_ccm_support branch from a3ba727 to aae843f Compare January 10, 2023 07:11

Prajyot-Parab reviewed Jan 10, 2023

View reviewed changes

main.go Outdated Show resolved Hide resolved

Karthik-K-N force-pushed the vpc_ccm_support branch from aae843f to 6510018 Compare January 10, 2023 07:22

k8s-ci-robot assigned Prajyot-Parab Jan 10, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023

Prajyot-Parab approved these changes Jan 10, 2023

View reviewed changes

mkumatag requested changes Jan 11, 2023

View reviewed changes

Karthik-K-N mentioned this pull request Jan 11, 2023

Deprecate powervs-provider-id-fmt flag #1024

Closed

Add external cloud provider support for VPC

a4fffc2

Karthik-K-N force-pushed the vpc_ccm_support branch from 6510018 to a4fffc2 Compare January 11, 2023 04:48

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023

mkumatag approved these changes Jan 12, 2023

View reviewed changes

k8s-ci-robot assigned mkumatag Jan 12, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023

k8s-ci-robot merged commit 31d5a80 into kubernetes-sigs:main Jan 12, 2023

Karthik-K-N mentioned this pull request Jan 16, 2023

Changes to deprecate powervs-provider-id-fmt flag #1032

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add external cloud provider support for VPC #1015

Add external cloud provider support for VPC #1015

Karthik-K-N commented Jan 4, 2023 •

edited

Loading

netlify bot commented Jan 4, 2023 •

edited

Loading

Karthik-K-N commented Jan 5, 2023

Prajyot-Parab commented Jan 10, 2023

mkumatag Jan 10, 2023

Karthik-K-N Jan 11, 2023

mkumatag Jan 10, 2023

mkumatag Jan 11, 2023

Karthik-K-N Jan 11, 2023

mkumatag Jan 11, 2023

mkumatag left a comment

k8s-ci-robot commented Jan 12, 2023

Add external cloud provider support for VPC #1015

Add external cloud provider support for VPC #1015

Conversation

Karthik-K-N commented Jan 4, 2023 • edited Loading

netlify bot commented Jan 4, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Karthik-K-N commented Jan 5, 2023

Prajyot-Parab commented Jan 10, 2023

mkumatag Jan 10, 2023

Choose a reason for hiding this comment

Karthik-K-N Jan 11, 2023

Choose a reason for hiding this comment

mkumatag Jan 10, 2023

Choose a reason for hiding this comment

mkumatag Jan 11, 2023

Choose a reason for hiding this comment

Karthik-K-N Jan 11, 2023

Choose a reason for hiding this comment

mkumatag Jan 11, 2023

Choose a reason for hiding this comment

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 12, 2023

Karthik-K-N commented Jan 4, 2023 •

edited

Loading

netlify bot commented Jan 4, 2023 •

edited

Loading