Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate powervs-provider-id-fmt flag #1024

Closed
Karthik-K-N opened this issue Jan 11, 2023 · 0 comments · Fixed by #1032
Closed

Deprecate powervs-provider-id-fmt flag #1024

Karthik-K-N opened this issue Jan 11, 2023 · 0 comments · Fixed by #1032
Assignees
@Karthik-K-N
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone
0.4.0

Comments

@Karthik-K-N
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

With the CCM support for VPC via #1015, We are introducing a generic flag named provider-id-fmt to set Provider ID format, We need deprecate the Power VS specific flag powervs-provider-id-fmt and use provider-id-fmt instead.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jan 11, 2023
@Karthik-K-N Karthik-K-N mentioned this issue Jan 11, 2023
Merged
@mkumatag mkumatag added this to the 0.4.0 milestone Jan 13, 2023
@Karthik-K-N Karthik-K-N mentioned this issue Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karthik-K-N Karthik-K-N

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Changes to deprecate powervs-provider-id-fmt flag Karthik-K-N/cluster-api-provider-ibmcloud
3 participants
@mkumatag @k8s-ci-robot @Karthik-K-N