Release 0.14.2 #713
Merged
Release 0.14.2 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CE-93: add organization class
move common constants to TestCommon
WIP CE-94: adding tests for us.kbase.workspace.database.Util
Update Organization to use checkOptionalPid Spaces ==> tabs
EMPTY => WHITESPACE in constant names
CE-93: implement PIDs; use shared constants
Switching tests over to CI whilst next is kaput
…ure for variable names
Co-authored-by: MrCreosote <MrCreosote@users.noreply.github.com>
Add build from ObjectInformation method
... and alter all the methods that touch object information to copy or return it correctly. Ideally we would've: * Made some type of field manager so mongo field lists aren't respecified all over the place * Added less integration-y tests for the altered methods in MongoWorkspaceDBTest, rather than jamming tests into WorkspaceTest However, that would have added several days to this project which we don't have.
Add method to set admin meta to DAO
Surprised it's not already there. Anyway, will be needed for the admin object metadata method and also allows us to clean up some other methods that were doing hacky things to get around it.
Add admin mode to PermissionsChecker
Add admin metadata setting method to workspace layer
Lots of whitespace changes since the last compile. Also it turns out the compile currently fails if there isn't a compiled constructor - I thought it used to add a blank constructor but maybe I'm misremembering.
Recompile spec
Add a get_admin_role API method
Add WorkspaceAdministration.ensureAdminRole
Needed for logging purposes
Return resolved objects from set admin data methods
Add API translation method for setting admin object metadata
+ integration tests
Implement API methods for admin object metadata
Constant changes don't automatically cause a recompilation which means tests that should've failed can pass
bump version, release notes
bump version, release notes
Bump version for release + update release notes
Bump version for release + update release notes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
============================================
+ Coverage 87.32% 87.66% +0.33%
- Complexity 5220 5328 +108
============================================
Files 223 228 +5
Lines 17363 17646 +283
Branches 2599 2573 -26
============================================
+ Hits 15163 15469 +306
+ Misses 1736 1714 -22
+ Partials 464 463 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes have been previously reviewed in their respective PRs