Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching tests over to CI whilst next is kaput #642

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

ialarmedalien
Copy link
Collaborator

As suggested in the PR title.

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And this is forever and ever, no need to switch back to next

@MrCreosote
Copy link
Member

MrCreosote commented Nov 3, 2022

we should wait for tests to pass before merge though, obvs

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #642 (72e4c61) into develop (3d71680) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #642   +/-   ##
==========================================
  Coverage      87.35%   87.35%           
  Complexity      5238     5238           
==========================================
  Files            224      224           
  Lines          17398    17398           
  Branches        2605     2605           
==========================================
  Hits           15198    15198           
  Misses          1736     1736           
  Partials         464      464           

@ialarmedalien ialarmedalien merged commit fd08855 into develop Nov 3, 2022
@ialarmedalien ialarmedalien deleted the move_tests_to_ci branch November 3, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants