Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix missing entries in help index #43251

Merged
merged 4 commits into from
May 11, 2024

Conversation

LadySolveig
Copy link
Contributor

Pull Request for Issue #32419 and related to PR #43250.

Summary of Changes

Add missing language strings for help index and generate toc.json.

Testing Instructions

Open the help index in the backend and check that all help documents are displayed.

grafik

Compare with https://docs.joomla.org/Category:Help_screen_5.0

Actual result BEFORE applying this Pull Request

Entries missing in index / TOC

Expected result AFTER applying this Pull Request

All entries are present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Apr 10, 2024
@LadySolveig
Copy link
Contributor Author

I would be grateful for help with the strings and would be very happy to receive a review here @brianteeman

@brianteeman
Copy link
Contributor

The strings are auto generated from the wiki so I wouldnt want to change them here as then they would need to be changed on the wiki as well, otherwise your build script will flag them as missing etc each time. So just merge this and be done with it.

(no idea how this works on a non-en-GB site)

@brianteeman
Copy link
Contributor

(perhaps my speedy test, review, comments and suggestions on your PR will free up some of your time to respond to my questiopns on my own PR)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on af07d01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

@Kostelano
Copy link
Contributor

Otherwise everything works, I tested it

- Content Security Policy Reports
- Content Security Policy: Options
@Kostelano
Copy link
Contributor

@LadySolveig For understanding: will there be a fix for COM_ADMIN_HELP_MENU_ITEM:_SEARCH="Menu Item: Search" or will it remain like this and I can submit a successful test now?

@LadySolveig
Copy link
Contributor Author

@Kostelano I would like to leave it as it is for now. Would be very happy about a successful test from you!

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 658ac55


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

@exlemor
Copy link

exlemor commented Apr 11, 2024

I have tested this item ✅ successfully on 658ac55

I was able to test this successfully. Thank you @LadySolveig


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

@growunder
Copy link

I have tested this item ✅ successfully on 658ac55

Tested successfully and noticed the missing translations, applied patch and it did correted those translations, although there are some missing options in the TOC comparing to the https://docs.joomla.org/Category:Help_screen_5.0 content:

Admin Modules: Logged-in Users
Admin Modules: User Menu
Cache: Clear Cache
Content Security Policy: Reports
Content Security Policy: Options
Information: Database
Information: Warnings
Maintenance: Global Check-in
Menu Item: Category Blog
Menu Item: Category List
Menu Item: Edit User Profile
Menu Item: List All Categories
Menu Item: List All Contact Categories
Menu Item: List All News Feed Categories
Menu Item: List Contacts in a Category
Menu Item: List News Feeds in a Category
Menu Item: User Profile
Menu Item: Username Reminder Request
Pernissions for User
Site Modules: Articles - Categories
Site Modules: Articles - Category
Site Modules: Latest Users
Site Modules: Who's Online
Site Modules: Indexed Content


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

@alikon
Copy link
Contributor

alikon commented Apr 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 11, 2024
@HLeithner HLeithner added the bug label Apr 24, 2024
@bembelimen bembelimen merged commit 91ef5da into joomla:5.1-dev May 11, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.1 milestone May 11, 2024
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 25, 2024
joomla/joomla-cms#43249 - (только для en-GB)
joomla/joomla-cms#43454 +
joomla/joomla-cms#43414 - (только для en-GB)
joomla/joomla-cms#43401 - (только для др. пакетов)
joomla/joomla-cms#43251 +
joomla/joomla-cms#43481 +
joomla/joomla-cms#43483 - (только для др. пакетов)
joomla/joomla-cms#43477 +
joomla/joomla-cms#43435 +
Kostelano added a commit to Joomla-Ukraine/uk-UA that referenced this pull request Jun 3, 2024
joomla/joomla-cms#43249 - (тільки для en-GB)
joomla/joomla-cms#43454 +
joomla/joomla-cms#43414 - (тільки для en-GB)
joomla/joomla-cms#43401 - (тільки для ін. пакетів)
joomla/joomla-cms#43251 +
joomla/joomla-cms#43481 +
joomla/joomla-cms#43483 - (тільки для ін. пакетів)
joomla/joomla-cms#43477 +
joomla/joomla-cms#43435 +
та інші виправлення
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants