-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Fix build tool helpTOC.php #43250
Conversation
- loop through all categories in all minor versions to get all media wiki categories for the major version - grap missing language strings into array - write missing strings to temporary file for revision and manually add to 'administrator/language/en-GB/com_admin.ini'
Co-authored-by: Brian Teeman <brian@teeman.net>
Definitely an improvement on the old script. Tested with en-GB only. Not sure how the process will work for other languages This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43250. |
I have tested this item ✅ successfully on accd60d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43250. |
I have tested this item ✅ successfully on accd60d I have reservations about adding 100+ missing strings to administrator/language/en-GB/com_admin.ini - that makes the list of Help pages more than twice as long and it is the only place where the missing strings are used. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43250. |
@ceford I agree with you about the language strings - I actually see this more as a partial fix to minimise rework in the wiki and still get the most up-to-date help index possible. |
When I looked at the strings it made me realise that the toc would benefit from nesting. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43250. |
Thanks! |
Pull Request for Issue #32419 .
Summary of Changes
Fix build tool for missing help documents in Help index.
/tmp/missing-helptoc.txt
for revision and manually add toadministrator/language/en-GB/com_admin.ini
Testing Instructions
composer i
php ./build/helpTOC.php
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed