Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] String sentence #43249

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[5.x] String sentence #43249

merged 1 commit into from
Apr 24, 2024

Conversation

brianteeman
Copy link
Contributor

Spotted while debugging

Summary of Changes

The error message is a sentence so it must end with a period

Testing Instructions

code review

Maintainers

No idea anymore which branch this shoud go in. Feel free to move it. As long as its fixed somewhere I dont care

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Apr 10, 2024
@wojsmol
Copy link
Contributor

wojsmol commented Apr 10, 2024

I have tested this item ✅ successfully on a495d5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

@chmst
Copy link
Contributor

chmst commented Apr 10, 2024

I have not tested this item.

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

@chmst
Copy link
Contributor

chmst commented Apr 10, 2024

I have tested this item ✅ successfully on a495d5c

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

@chmst chmst removed Language Change This is for Translators PR-5.1-dev labels Apr 10, 2024
@chmst
Copy link
Contributor

chmst commented Apr 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

@chmst
Copy link
Contributor

chmst commented Apr 10, 2024

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 10, 2024
@chmst chmst added this to the Joomla! 5.2.0 milestone Apr 10, 2024
@richard67 richard67 added PR-5.1-dev Language Change This is for Translators labels Apr 14, 2024
@richard67
Copy link
Member

@chmst Are you sure the milestone 5.2.0 which you have set is right? Or did you want to set 5.1.1 (which doesn't exist yet)?

@HLeithner HLeithner merged commit b947df6 into joomla:5.1-dev Apr 24, 2024
3 of 5 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 24, 2024
@HLeithner HLeithner added RTC This Pull Request is Ready To Commit bug labels Apr 24, 2024
@brianteeman
Copy link
Contributor Author

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 24, 2024
@brianteeman brianteeman deleted the patch-5 branch April 24, 2024 08:18
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 25, 2024
joomla/joomla-cms#43249 - (только для en-GB)
joomla/joomla-cms#43454 +
joomla/joomla-cms#43414 - (только для en-GB)
joomla/joomla-cms#43401 - (только для др. пакетов)
joomla/joomla-cms#43251 +
joomla/joomla-cms#43481 +
joomla/joomla-cms#43483 - (только для др. пакетов)
joomla/joomla-cms#43477 +
joomla/joomla-cms#43435 +
Kostelano added a commit to Joomla-Ukraine/uk-UA that referenced this pull request Jun 3, 2024
joomla/joomla-cms#43249 - (тільки для en-GB)
joomla/joomla-cms#43454 +
joomla/joomla-cms#43414 - (тільки для en-GB)
joomla/joomla-cms#43401 - (тільки для ін. пакетів)
joomla/joomla-cms#43251 +
joomla/joomla-cms#43481 +
joomla/joomla-cms#43483 - (тільки для ін. пакетів)
joomla/joomla-cms#43477 +
joomla/joomla-cms#43435 +
та інші виправлення
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants