Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the directory structure + Improve test coverage and uniform code by @krufab #49

Merged
merged 5 commits into from
Apr 12, 2020
Merged

Change the directory structure + Improve test coverage and uniform code by @krufab #49

merged 5 commits into from
Apr 12, 2020

Conversation

slide
Copy link
Member

@slide slide commented Apr 4, 2020

Based on the work of @krufab in jenkinsci/docker-agent#105

  • Reworks directory structure similar to openjdk/AdoptOpenJDK for JDK versions and OS versions
  • Adds tests for Windows containers
  • Add Dockerfiles for nanoserver
  • Updates Jenkinsfile to build Windows images correctly and push to dockerhub

@slide slide requested a review from a team as a code owner April 4, 2020 13:12
@oleg-nenashev
Copy link
Member

We will need to reconfigure DockerHub as well. Will try to take a look this weekend

@oleg-nenashev oleg-nenashev mentioned this pull request Apr 11, 2020
Closed
@slide
Pull in changes from #48
f11af69 
Also, remove as many references to "slave" as possible while retaining backward compatibility.
@oleg-nenashev oleg-nenashev changed the title Directory changes Change the directory structure + Improve test coverage and uniform code Apr 12, 2020
@oleg-nenashev oleg-nenashev merged commit 31bff42 into jenkinsci:master Apr 12, 2020
@oleg-nenashev oleg-nenashev changed the title Change the directory structure + Improve test coverage and uniform code Change the directory structure + Improve test coverage and uniform code by @krufab Apr 12, 2020
@oleg-nenashev oleg-nenashev mentioned this pull request Apr 12, 2020
Closed
@slide slide deleted the directory_changes branch April 13, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@MarkEWaite MarkEWaite Awaiting requested review from MarkEWaite

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slide @oleg-nenashev