Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests and align code with docker-slave/jnlp #47

Closed
krufab opened this issue Jan 17, 2020 · 3 comments
Closed

Improve tests and align code with docker-slave/jnlp #47

krufab opened this issue Jan 17, 2020 · 3 comments

Comments

@krufab
Copy link
Contributor

krufab commented Jan 17, 2020

The code of the tests can be improved and should be aligned with the one in https://github.com/jenkinsci/docker-slave and https://github.com/jenkinsci/docker-jnlp-slave

@oleg-nenashev
Copy link
Member

I suppose it is addressed by #48 and #49, right?

@krufab
Copy link
Contributor Author

krufab commented Apr 12, 2020

Yes, I think it can be closed

@oleg-nenashev
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants