Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests and uniform code #48

Closed
wants to merge 7 commits into from
Closed

Improve tests and uniform code #48

wants to merge 7 commits into from

Conversation

krufab
Copy link
Contributor

@krufab krufab commented Jan 17, 2020

@krufab krufab requested a review from a team as a code owner January 17, 2020 00:39
@krufab krufab changed the title Add test and uniform code Improve tests and uniform code Jan 17, 2020
slide
slide suggested changes Jan 21, 2020
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
krufab
krufab commented Jan 21, 2020
View reviewed changes
Copy link
Contributor Author

@krufab krufab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code according to PR review

Jenkinsfile Outdated Show resolved Hide resolved
@krufab krufab requested a review from slide January 21, 2020 21:25
slide
slide reviewed Jan 21, 2020
View reviewed changes
Jenkinsfile Show resolved Hide resolved
@krufab
Copy link
Contributor Author

krufab commented Jan 27, 2020

Is it ok this PR or is there anything to change?

@oleg-nenashev
Copy link
Member

@slide how does it align with #49? Looks like merge conflicts will be fun. Would you be able to integrate merge this PR into your pull request?

@slide
Copy link
Member

slide commented Apr 11, 2020

Yes, I can do that

@slide
Copy link
Member

slide commented Apr 11, 2020

This is now superseded by #49

@oleg-nenashev
Copy link
Member

Thanks @krufab ! I am closing it since the code was integrated into #49 . I will make sure that the changelog attributes this change properly

@oleg-nenashev oleg-nenashev mentioned this pull request Apr 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krufab @oleg-nenashev @slide