Skip to content

Commit

Permalink
🔖 0.15.8 fix rare Gradle version parse bug
Browse files Browse the repository at this point in the history
  • Loading branch information
calvertdw committed Jul 8, 2019
1 parent d75ba3f commit ed2db05
Show file tree
Hide file tree
Showing 26 changed files with 29 additions and 27 deletions.
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

group = "us.ihmc"
version = "0.15.7"
version = "0.15.8"

java {
sourceCompatibility = JavaVersion.VERSION_1_8
Expand Down
6 changes: 4 additions & 2 deletions src/main/kotlin/us/ihmc/build/Version.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package us.ihmc.build

class Version(private val version: String) : Comparable<Version>
class Version(private val rawVersion: String) : Comparable<Version>
{
private val version = rawVersion.trim().split("-").get(0)

init {
if (!version.matches("[0-9]+(\\.[0-9]+)*".toRegex()))
if (version.isBlank() || !version.matches("[0-9]+(\\.[0-9]+)*".toRegex()))
throw IllegalArgumentException("Invalid version format: $version")
}

Expand Down
2 changes: 1 addition & 1 deletion tests/basicProject/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}
apply plugin: "us.ihmc.ihmc-build"
Expand Down
2 changes: 1 addition & 1 deletion tests/basicProject/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/dependsOnSnapshot/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
classpath "us.ihmc:ihmc-ci-plugin:0.18.0"
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/dependsOnSnapshot/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/emptyBuildGradleProject/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/generateTestSuitesTest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
classpath "us.ihmc:ihmc-ci-plugin:0.18.0"
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/generateTestSuitesTest/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/multi-project-composite-source-sets/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
plugins {
id("us.ihmc.ihmc-build") version "0.15.7"
id("us.ihmc.ihmc-build") version "0.15.8"
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("us.ihmc:ihmc-build:0.15.7")
classpath("us.ihmc:ihmc-build:0.15.8")
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id("us.ihmc.ihmc-build") version "0.15.7"
id("us.ihmc.ihmc-build") version "0.15.8"
}

ihmc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("us.ihmc:ihmc-build:0.15.7")
classpath("us.ihmc:ihmc-build:0.15.8")
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id("us.ihmc.ihmc-build") version "0.15.7"
id("us.ihmc.ihmc-build") version "0.15.8"
}

ihmc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("us.ihmc:ihmc-build:0.15.7")
classpath("us.ihmc:ihmc-build:0.15.8")
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id("us.ihmc.ihmc-build") version "0.15.7"
id("us.ihmc.ihmc-build") version "0.15.8"
}

ihmc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("us.ihmc:ihmc-build:0.15.7")
classpath("us.ihmc:ihmc-build:0.15.8")
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/multi-project-inconsistent-excludes/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/multi-project/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/multi-project/sub-project-one/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/multi-project/sub-project-two/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/oldPublishApiTest/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/publishApiTest/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath "us.ihmc:ihmc-build:0.15.7"
classpath "us.ihmc:ihmc-build:0.15.8"
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/resource-loading/settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("us.ihmc:ihmc-build:0.15.7")
classpath("us.ihmc:ihmc-build:0.15.8")
}
}

Expand Down

0 comments on commit ed2db05

Please sign in to comment.