Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize loops #24

Merged

Conversation

tbnritzdoge
Copy link
Member

Simple loop optimizations that should've been done the first time we redid our loops(sorry).

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

coverage: 98.678% (+0.04%) from 98.643%
when pulling e72887a on tbnritzdoge:perf/loops-optimization
into 26d84e2 on helperdiscord:master.

Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll remove the prefer for of and no plus plus lint rules later, since they are somewhat useless, and don't follow organization style guide.

@tbnritzdoge tbnritzdoge merged commit 01b8012 into helperdiscord:master Apr 12, 2021
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))
* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))
* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.3.0](v1.2.1...v1.3.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants