Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove spread operators and callback loops #12

Merged

Conversation

tbnritzdoge
Copy link
Member

@coveralls
Copy link

coveralls commented Apr 4, 2021

Coverage Status

Changes unknown
when pulling 1e4d578 on tbnritzdoge:chore/remove-spread-operator
into ** on helperdiscord:master**.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.633% when pulling ec548e1 on tbnritzdoge:chore/remove-spread-operator into d8344e4 on helperdiscord:master.

@tbnritzdoge tbnritzdoge requested review from Nytelife26 and removed request for Nytelife26 April 4, 2021 21:51
@tbnritzdoge tbnritzdoge changed the title chore(perf): remove spread operators in favor of Object.assign chore(perf): minor all-round improvements Apr 4, 2021
Vetlix
Vetlix previously approved these changes Apr 4, 2021
Copy link
Collaborator

@Vetlix Vetlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nytelife26
Copy link
Collaborator

Unsure as to how this will play out with latest linting rules. Putting this on hold until docs gets merged.

@Nytelife26 Nytelife26 marked this pull request as draft April 7, 2021 13:54
@Nytelife26
Copy link
Collaborator

Designating as draft until the docs PR is merged and we can reach 100% coverage.

@tbnritzdoge tbnritzdoge changed the base branch from master to ci/docs April 7, 2021 13:59
@Nytelife26 Nytelife26 changed the base branch from ci/docs to master April 7, 2021 14:43
@helperdiscord helperdiscord deleted a comment from tbnritzdoge Apr 7, 2021
@Nytelife26 Nytelife26 force-pushed the chore/remove-spread-operator branch from e8d2517 to dac2abb Compare April 7, 2021 15:07
@Nytelife26 Nytelife26 marked this pull request as ready for review April 7, 2021 15:38
@Nytelife26 Nytelife26 changed the title chore(perf): minor all-round improvements perf: remove spread operators and callback loops Apr 7, 2021
Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Vetlix Vetlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbnritzdoge tbnritzdoge merged commit 3bf48cc into helperdiscord:master Apr 7, 2021
github-actions bot pushed a commit that referenced this pull request Apr 7, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-07)

### Bug Fixes

* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Nytelife26 pushed a commit that referenced this pull request Apr 7, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-07)

### Bug Fixes

* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot pushed a commit that referenced this pull request Apr 8, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-08)

### Bug Fixes

* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))
* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))
* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants