Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abort-controllers #23

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

tbnritzdoge
Copy link
Member

No description provided.

@tbnritzdoge tbnritzdoge linked an issue Apr 12, 2021 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

coverage: 98.739% (+0.06%) from 98.678%
when pulling 9ee59d1 on tbnritzdoge:feat/abort-signal
into 01b8012 on helperdiscord:master.

Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a usage example for how one would abort the request? I can see people asking about that in the future.

src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a better example writeup.

src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2021

This pull request introduces 106 alerts when merging 3bf635f into 01b8012 - view on LGTM.com

new alerts:

  • 106 for Syntax error

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>
@Nytelife26 Nytelife26 merged commit c1a0b1c into helperdiscord:master Apr 12, 2021
Nytelife26 added a commit that referenced this pull request Apr 12, 2021
Nytelife26 added a commit that referenced this pull request Apr 12, 2021
* feat: support abort-controllers

* docs: document abort controllers

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>
Nytelife26 added a commit that referenced this pull request Apr 12, 2021
* feat: support abort-controllers

* docs: document abort controllers

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))
* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))
* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.3.0](v1.2.1...v1.3.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: request aborting signal
3 participants