fix: change build target for backwards compat #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an unnecessary code quality sacrifice when we can simply adjust our build settings. You can set the target to either ES2018 or Node12 in our ESBuild config to resolve this more effectively without needing to sacrifice developer experience. |
tbnritzdoge
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13) ### Bug Fixes * change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3)) * **ci:** make filepaths correct ([9299fc0](9299fc0)) * **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4)) ### Features * abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d)) * add all http methods ([#17](#17)) ([f869666](f869666)) * **ci:** build on every commit ([443070b](443070b)) * add support for stream ([c706801](c706801)) * add text encoding option & tests ([7f6f5c6](7f6f5c6)) ### Performance Improvements * improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2)) * optimize loops ([#24](#24)) ([01b8012](01b8012)) * remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
# [1.3.0](v1.2.1...v1.3.0) (2021-04-13) ### Bug Fixes * change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3)) * **ci:** make filepaths correct ([9299fc0](9299fc0)) ### Features * abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d)) * add all http methods ([#17](#17)) ([f869666](f869666)) * **ci:** build on every commit ([443070b](443070b)) ### Performance Improvements * improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2)) * optimize loops ([#24](#24)) ([01b8012](01b8012))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.