Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all http methods #17

Merged
merged 5 commits into from
Apr 9, 2021
Merged

feat: add all http methods #17

merged 5 commits into from
Apr 9, 2021

Conversation

HeadTriXz
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.627% when pulling 0e33c98 on HeadTriXz:master into bec5c13 on helperdiscord:master.

@coveralls
Copy link

coveralls commented Apr 8, 2021

Coverage Status

coverage: 98.627%. remained the same
when pulling 67d1f34 on HeadTriXz:master
into 4aac817 on helperdiscord:master.

Copy link
Member

@tbnritzdoge tbnritzdoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tbnritzdoge tbnritzdoge changed the title Add "HEAD" method feat: add HEAD to methods Apr 8, 2021
Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the PR! I think while we're at it, we might as well add all the other request methods from HTTP/1.0 and HTTP/1.1 too, so if you can commit these we're good to go :)

src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
HeadTriXz and others added 3 commits April 9, 2021 06:57
Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>
@HeadTriXz HeadTriXz changed the title feat: add HEAD to methods feat: add all methods Apr 9, 2021
@tbnritzdoge tbnritzdoge changed the title feat: add all methods feat: add all http methods Apr 9, 2021
Copy link
Collaborator

@Vetlix Vetlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Merging now :)

@Nytelife26 Nytelife26 merged commit f869666 into helperdiscord:master Apr 9, 2021
tbnritzdoge pushed a commit that referenced this pull request Apr 12, 2021
* Update PetitioRequest.ts

* Update petitiorequest.md

* Update src/lib/PetitioRequest.ts

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>

* Update docs

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))
* **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))
* add support for stream ([c706801](c706801))
* add text encoding option & tests ([7f6f5c6](7f6f5c6))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
* remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
github-actions bot pushed a commit that referenced this pull request Apr 13, 2021
# [1.3.0](v1.2.1...v1.3.0) (2021-04-13)

### Bug Fixes

* change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3))
* **ci:** make filepaths correct ([9299fc0](9299fc0))

### Features

* abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d))
* add all http methods ([#17](#17)) ([f869666](f869666))
* **ci:** build on every commit ([443070b](443070b))

### Performance Improvements

* improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2))
* optimize loops ([#24](#24)) ([01b8012](01b8012))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants