fix(PetitioResponse): support non-ascii json responses #11
Conversation
|
Ah, no problem if you prefer to delete the |
There was a problem hiding this comment.
Once the Korean Tests are removed this looks good to merge although we may want to incorporate a encoding type in buffer#toString like in PetitioResponse#text. I will invoke @Nytelife26 to see his opinion on that. Thanks for the PR :)
There was a problem hiding this comment.
Once the Korean Tests are removed this looks good to merge although we may want to incorporate a encoding type in buffer#toString like in PetitioResponse#text. I will invoke @Nytelife26 to see his opinion on that. Thanks for the PR :)
There was a problem hiding this comment.
Once the Korean Tests are removed this looks good to merge although we may want to incorporate a encoding type in buffer#toString like in PetitioResponse#text. I will invoke @Nytelife26 to see his opinion on that. Thanks for the PR :)
|
Apologies for spamming this, my internet was having issues. |
|
@tbnritzdoge applied edits for change requests as you requested 👍 |
|
The reason we didn't use |
Nytelife26
changed the title
|
Nevermind, looks good to me. Ready to merge once CI passes. |
# [1.2.0](v1.1.0...v1.2.0) (2021-04-07) ### Bug Fixes * **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4)) ### Features * add support for stream ([c706801](c706801)) * add text encoding option & tests ([7f6f5c6](7f6f5c6)) ### Performance Improvements * remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.2.0](v1.1.0...v1.2.0) (2021-04-07) ### Bug Fixes * **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4)) ### Features * add support for stream ([c706801](c706801)) * add text encoding option & tests ([7f6f5c6](7f6f5c6)) ### Performance Improvements * remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
# [1.2.0](v1.1.0...v1.2.0) (2021-04-08) ### Bug Fixes * **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4)) ### Features * add support for stream ([c706801](c706801)) * add text encoding option & tests ([7f6f5c6](7f6f5c6)) ### Performance Improvements * remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
# [1.2.0](v1.1.0...v1.2.0) (2021-04-13) ### Bug Fixes * change build target for backwards compat ([#25](#25)) ([87cbbd3](87cbbd3)) * **ci:** make filepaths correct ([9299fc0](9299fc0)) * **PetitioResponse:** support non-ascii json responses ([#11](#11)) ([d8344e4](d8344e4)) ### Features * abort-controllers ([#23](#23)) ([1ad4a5d](1ad4a5d)) * add all http methods ([#17](#17)) ([f869666](f869666)) * **ci:** build on every commit ([443070b](443070b)) * add support for stream ([c706801](c706801)) * add text encoding option & tests ([7f6f5c6](7f6f5c6)) ### Performance Improvements * improve response buffer handling ([#20](#20)) ([26d84e2](26d84e2)) * optimize loops ([#24](#24)) ([01b8012](01b8012)) * remove spread operators and callback loops ([#12](#12)) ([3bf48cc](3bf48cc))
Closes #10
Using Buffer#toString fixed this because it parses string to utf-8 automatically.