Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle script timeout as script preferences instead of server preference #509

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Oct 20, 2021

What

Currently is sent to openvas as timeout.
Now is sent as as a script preference as param with ID 0 subelemet of the vt_single in the vt_selection.

[main branch] All related PRs:

Why:
To handle the timeout consistently as script preference between scanner and gvmd

How did you test it:
Set a custom timeout for a script and check that the timeout is accepted.What:
Handle script timeout as script preferences instead of server preference

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola requested a review from a team as a code owner October 20, 2021 08:25
@jjnicola jjnicola enabled auto-merge (squash) October 20, 2021 08:30
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #509 (c9f3ebf) into main (b8f9a7e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   80.25%   80.16%   -0.09%     
==========================================
  Files          10       10              
  Lines        1666     1649      -17     
==========================================
- Hits         1337     1322      -15     
+ Misses        329      327       -2     
Impacted Files Coverage Δ
ospd_openvas/db.py 97.05% <ø> (ø)
ospd_openvas/nvticache.py 94.01% <100.00%> (+0.07%) ⬆️
ospd_openvas/preferencehandler.py 90.19% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f9a7e...c9f3ebf. Read the comment docs.

@jjnicola jjnicola enabled auto-merge (squash) October 20, 2021 08:52
@jjnicola jjnicola merged commit af97d06 into greenbone:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants