Store and get the script timeout as preference #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2021
get_plugin_prefrence() already checks first for preferences set by the client, if not found get the default from redis.
The id 0 was not handled because it was reserved for the timeout, stored in other place with another format. Now, the timeout is handle as plugin preference and can be handled via its ID. Although, ID 0 is still reserved for the timeout plugin preference.
jjnicola
force-pushed
the
timeout-master
branch
from
01aa174
to
d623609
Compare
ArnoStiefvater
approved these changes
Oct 19, 2021
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on greenbone/gvm-libs#581
What:
Store and get the script timeout as preference
[middleware branch] All related PRs:
[master branch] All related PRs:
Why:
The script timeout is now handle as preference and it is stored as another preference, but always with the ID 0.
How:
Use an up to date build of middleware from gvmd (send the script preference) and gvm-libs (handle timeout as preference)
Set a timeout to 1second for a script in gsa, one which runs for a long time (find_service.nasl). Run the scanner. Check that the script timeouts. You can check this with "log_whole_attack = yes"
A redis flushall() is required, since it is a change in the redis nvticache and all plugins must be loaded up again.
Checklist: