Handle script timeout as script preference #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
master-timeout
branch
from
4cb8480
to
3c38e79
Compare
2 tasks
This was referenced Aug 18, 2021
Because it is now handle as script preference.
The timeout is not stored under the redis key `nvt:<OID>` anymore.
The timeout must be get from script preferences. It was currently not used by libs or scanner.
jjnicola
force-pushed
the
master-timeout
branch
from
3c38e79
to
607179b
Compare
ArnoStiefvater
approved these changes
Oct 18, 2021
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Handle script timeout as script preference
[middleware branch] All related PRs:
[master branch] All related PRs:
Why:
Timeout is a script preference, it had reserved the preference ID 0, but it is currently handled in a different way. With this patch, it is just another preference (always with the reserved pref. ID 0)
How:
Checklist: