fix: Update Loki v3 Helm statefulset-ingester.yaml template #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the "-ingester.ring.instance-availability-zone=zone-default" parameter.
|
|
lindeskar
reviewed
Jun 5, 2024
7 tasks
Adding back the argument in its correct syntax
Co-authored-by: Alexander Lindeskär <lindeskar@users.noreply.github.com>
|
LGTM. Does not need any if statement. |
bulmust
approved these changes
Jun 25, 2024
lindeskar
approved these changes
Jun 27, 2024
|
@Arno-Pretorius accept the Contributor license aggrement please |
@Ronan-WeScale Done, thank you |
|
please merge this |
|
@grafana-labs-se-svc Can we get some action on this item please? |
MasslessParticle
changed the title
MasslessParticle
approved these changes
Jul 10, 2024
|
@MasslessParticle When can we get a patch release pushed with this fix? Without it, our team is completely blocked from the migration off of |
|
The fix has been published with in the latest release https://github.com/grafana/helm-charts/releases/tag/helm-loki-6.7.1 |
This was referenced Aug 15, 2024
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…13118) Co-authored-by: Alexander Lindeskär <lindeskar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the "-ingester.ring.instance-availability-zone=zone-default" parameter.
What this PR does / why we need it:
This parameter is giving an error "loki ingester not starting: flag not defined: -ingester.ring.instance-availability-zone" on the ingester service as seen in this logged Github/Loki issue #13061.
I Updated the parameter to "-ingester.availability-zone" in my Live manifest and then my Loki Ingester deployed and started to make index entries etc.
This parameter is required I am not sure if the fix should rather be made on the ingester service itself and not in the statefulset to reflect the correct value.
Which issue(s) this PR fixes:
Fixes ##13061
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR