Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki ingester not starting: flag not defined: -ingester.ring.instance-availability-zone #13061

Closed
kirankumar-grootan opened this issue May 29, 2024 · 11 comments
Labels
area/helm component/ingester type/bug Somehing is not working as expected

Comments

@kirankumar-grootan
Copy link

kirankumar-grootan commented May 29, 2024

when installing loki 6.6.2 helm chart in distributed mode. ingesters are not starting it says
https://github.com/grafana/loki/blob/main/production/helm/loki/templates/ingester/statefulset-ingester.yaml#L90

loki flag provided but not defined: -ingester.ring.instance-availability-zone
Run with -help to get list of available parameters

as per doc i dont find any argument

this version of chart is installing loki version 3.0.0

pls make pod anti affinity as empty in chart by default
or its good to add app.kubernetes.io/name: loki label to affinity selector as it is getting conflicted with other ingester (mimir, tempo etc) and pod not scheduling

@kirankumar-grootan kirankumar-grootan changed the title loki flag not defined: -ingester.ring.instance-availability-zone loki not starting: flag not defined: -ingester.ring.instance-availability-zone May 30, 2024
@kirankumar-grootan kirankumar-grootan changed the title loki not starting: flag not defined: -ingester.ring.instance-availability-zone loki ingester not starting: flag not defined: -ingester.ring.instance-availability-zone May 30, 2024
@Arno-Pretorius
Copy link
Contributor

I am getting the same error as above and I am using Loki with Helm Chart 6.6.0 using Loki version 3.0.0

@kirankumar-grootan
Copy link
Author

kirankumar-grootan commented May 30, 2024

yes! as per the Loki doc this argument is available for other Loki components but not for Ingester. even Mimir has this argument documented under Ingester and few other Mimir components

@Arno-Pretorius
Copy link
Contributor

I created this PR because if I remove the parament from my live manifest my Ingester deploys and functions normally. #13118

@lindeskar
Copy link
Contributor

Shouldn't it be ingester.availability-zone like in the zone-aware StatefulSets?

It's also documented in: https://grafana.com/docs/loki/latest/configure/#ingester

@Arno-Pretorius
Copy link
Contributor

Shouldn't it be ingester.availability-zone like in the zone-aware StatefulSets?

It's also documented in: https://grafana.com/docs/loki/latest/configure/#ingester

Dis changes works I made the change in my Live manifest and the pods are running fine now.

@kirankumar-grootan
Copy link
Author

kirankumar-grootan commented Jun 19, 2024

@Arno-Pretorius @lindeskar any ETA when this PR #13118 will be merged?

@lindeskar
Copy link
Contributor

@kirankumar-grootan I also want it fixed, but I'm not a maintainer. 🤷🏻

@rlees85
Copy link

rlees85 commented Jun 20, 2024

@Arno-Pretorius @lindeskar any ETA when this PR #13118 will be merged?

When one of the two contributors who have submitted PRs (thanks both btw) implement the requested changes ... Hopefully soon or I'll have to submit a third.

I'm not a maintainer by the way, this isn't an authoritative response but its what I assume is holding it up

@Arno-Pretorius
Copy link
Contributor

Arno-Pretorius commented Jun 25, 2024

@lindeskar and @bulmust I updated the PR with the new changes and Reset the review just waiting for approval the argument is now set to "-ingester.availability-zone=zone-default"

@kirankumar-grootan
Copy link
Author

@cyriltovena, I apologize for tagging you directly, but we haven't received any response on this issue for weeks. Could you please take a look at this issue? appreciate your help. Thank you!

@kirankumar-grootan
Copy link
Author

6.6.6 helm chart has been published with the fix.

Thank you all for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm component/ingester type/bug Somehing is not working as expected
Projects
None yet
Development

No branches or pull requests

5 participants