Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ingester/helm zoneAwareness #13251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Atom-oh
Copy link

@Atom-oh Atom-oh commented Jun 18, 2024

  • -ingester.ring.instance-availability-zone=zone-default

What this PR does / why we need it:
flag provided but not defined: -ingester.ring.instance-availability-zone

flag provided but not defined: -ingester.ring.instance-availability-zone
Run with -help to get list of available parameters

Which issue(s) this PR fixes:
Fixes #
#13250
#13250
Special notes for your reviewer:
hpa on ingester has some typo, so I updated on it
Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

- -ingester.ring.instance-availability-zone=zone-default
@Atom-oh Atom-oh requested a review from a team as a code owner June 18, 2024 07:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rlees85
Copy link

rlees85 commented Jun 18, 2024

See: #13118

The author of the other PR seems to have disappeared though, so please don't close this! Just see the comment near the bottom about -ingester.availability-zone=zone-default. tldr, you don't need to remove the argument, just change it to the correct argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants