chore: start generating storage v2 gapic #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
|
@BenWhitehead @danielduhh beginning generation of the Java GAPIC for v2 was requested by the API team. I've never set up a Java GAPIC in a repo before so I'm not sure what should be done. Ben, do you know how to wire things up dependency wise? We probably want to add some disclaimer that this client shouldn't be used directly and that the Veneer should be used still. |
|
We'll need googleapis/synthtool#1160 to merge into synthool before we can merge this. |
BenWhitehead
added
the
do not merge
BenWhitehead
force-pushed
the
v2-gapic
branch
2 times, most recently
from
5cfab7f
to
d6acdab
Compare
|
Issue for name collisions with |
BenWhitehead
force-pushed
the
v2-gapic
branch
2 times, most recently
from
730b270
to
cb78bfc
Compare
BenWhitehead
approved these changes
Aug 11, 2021
BenWhitehead
removed
the
do not merge
BenWhitehead
approved these changes
Aug 11, 2021
|
Failing dependency builds will pass after code is generated, I'm going to manually trigger it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GAPIC generation target for Storage API v2.