Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gRPC channels to GCS v2 APIs #590

Merged
merged 14 commits into from
Aug 17, 2021

Conversation

mprashanthsagar
Copy link
Contributor

No description provided.

@mprashanthsagar
Copy link
Contributor Author

mprashanthsagar commented Aug 3, 2021

/gcbrun

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #590 (28b3b23) into master (96acdcd) will increase coverage by 0.01%.
The diff coverage is 90.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
+ Coverage     80.25%   80.26%   +0.01%     
- Complexity     2085     2087       +2     
============================================
  Files           142      143       +1     
  Lines          9155     9160       +5     
  Branches       1086     1088       +2     
============================================
+ Hits           7347     7352       +5     
+ Misses         1359     1358       -1     
- Partials        449      450       +1     
Flag Coverage Δ
hadoop2integrationtest 60.11% <77.35%> (-0.02%) ⬇️
hadoop2unittest 68.58% <90.56%> (+0.01%) ⬆️
hadoop3integrationtest 60.07% <77.35%> (-0.08%) ⬇️
hadoop3unittest 68.62% <90.56%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adoop/gcsio/GoogleCloudStorageGrpcReadChannel.java 84.90% <87.50%> (ø)
...doop/gcsio/GoogleCloudStorageGrpcWriteChannel.java 77.07% <91.17%> (-0.53%) ⬇️
...om/google/cloud/hadoop/gcsio/GrpcChannelUtils.java 100.00% <100.00%> (ø)
...google/cloud/hadoop/gcsio/StorageStubProvider.java 77.60% <100.00%> (ø)
...ogle/cloud/hadoop/gcsio/PrefixMappedItemCache.java 67.53% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96acdcd...28b3b23. Read the comment docs.

@mprashanthsagar mprashanthsagar marked this pull request as ready for review August 4, 2021 09:53
@mprashanthsagar
Copy link
Contributor Author

Once #594 and #595 are merged, and this PR is re-based, a lot of formatting changes would be removed.

.gitmodules Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
gcsio/pom.xml Show resolved Hide resolved
gcsio/pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@mprashanthsagar mprashanthsagar merged commit 9e14bea into GoogleCloudDataproc:master Aug 17, 2021
mprashanthsagar added a commit to mprashanthsagar/hadoop-connectors that referenced this pull request Aug 19, 2021
@mprashanthsagar mprashanthsagar deleted the submodule branch November 29, 2021 16:05
mayanks pushed a commit to mayanks/hadoop-connectors that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants