chore: add preserve_gapic to java library generation options #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases when generating a library, the gapic directory prefix should be preserved (veneer clients for example). This feature adds a new parameter `preserve_gapic` to `java.gapic_library` and `java.bazel_library`.
BenWhitehead
requested review from
bcoe,
chingor13 and
SurferJeffAtGoogle
as code owners
google-cla
bot
added
the
cla: yes
chingor13
approved these changes
Jul 20, 2021
chingor13
changed the title
|
Changed to a "chore" because this does trigger a new docker image build and the commit message would be a |
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when generating a library the gapic directory prefix should be preserved (veneer clients for example). This feature adds a new parameter
preserve_gapictojava.gapic_libraryandjava.bazel_library