Store read access in access for team repositories #20275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently when a Team has read access to a organization's non-private repository, their access won't be stored in the database. This caused issue for code that rely on read access being stored. So from now-on if we see that the repository is owned by a organization don't increase the minMode to write permission. - Resolves go-gitea#20083
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Jul 6, 2022
- Backport go-gitea#20275 - Currently when a Team has read access to a organization's non-private repository, their access(in the `access` table) won't be stored in the database. This cause issues for code that rely on read access being stored, like retrieving all users who have read permission to that repository(even though this is confusing as this doesn't include all registered users). So from now-on if we see that the repository is owned by a organization don't increase the `minMode` to write permission. - Resolves go-gitea#20083
6543
approved these changes
Jul 7, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
changed the title
zeripath
approved these changes
Jul 9, 2022
GiteaBot
added
lgtm/done
6543
pushed a commit
that referenced
this pull request
Jul 9, 2022
Backport #20275 Currently when a Team has read access to a organization's non-private repository, their access(in the `access` table) won't be stored in the database. This cause issues for code that rely on read access being stored, like retrieving all users who have read permission to that repository(even though this is confusing as this doesn't include all registered users). So from now-on if we see that the repository is owned by a organization don't increase the `minMode` to write permission. Resolves #20083
Codecov Report
@@ Coverage Diff @@
## main #20275 +/- ##
==========================================
+ Coverage 46.73% 46.94% +0.20%
==========================================
Files 976 976
Lines 135007 135010 +3
==========================================
+ Hits 63101 63381 +280
+ Misses 64208 63864 -344
- Partials 7698 7765 +67
Continue to review full report at Codecov.
|
|
true |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 12, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add spectral linter for Swagger (go-gitea#20321) Store read access in access for team repo's (go-gitea#20275)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
- Currently when a Team has read access to a organization's non-private repository, their access won't be stored in the database. This caused issue for code that rely on read access being stored. So from now-on if we see that the repository is owned by a organization don't increase the minMode to write permission. - Resolves go-gitea#20083
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accesstable) won't be stored in the database. This cause issues for code that rely on read access being stored, like retrieving all users who have read permission to that repository(even though this is confusing as this doesn't include all registered users). So from now-on if we see that the repository is owned by a organization don't increase theminModeto write permission.