Skip to content

Commit

Permalink
Store read access in access for team repo's (go-gitea#20275)
Browse files Browse the repository at this point in the history
- Currently when a Team has read access to a organization's non-private
repository, their access won't be stored in the database. This caused
issue for code that rely on read access being stored. So from now-on if
we see that the repository is owned by a organization don't increase the
minMode to write permission.
- Resolves go-gitea#20083
  • Loading branch information
Gusted authored and Sysoev, Vladimir committed Aug 10, 2022
1 parent ba3d4a2 commit 747e74b
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion models/perm/access/access.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,13 @@ func updateUserAccess(accessMap map[int64]*userAccess, user *user_model.User, mo
// FIXME: do cross-comparison so reduce deletions and additions to the minimum?
func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap map[int64]*userAccess) (err error) {
minMode := perm.AccessModeRead
if !repo.IsPrivate {
if err := repo.GetOwner(ctx); err != nil {
return fmt.Errorf("GetOwner: %v", err)
}

// If the repo isn't private and isn't owned by a organization,
// increase the minMode to Write.
if !repo.IsPrivate && !repo.Owner.IsOrganization() {
minMode = perm.AccessModeWrite
}

Expand Down

0 comments on commit 747e74b

Please sign in to comment.