Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store read access in access for team repositories #20275

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Store read access in access for team repositories #20275

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e83db34
Store read access in access for team repo's
Jul 6, 2022
d105211
Merge branch 'main' into store-team-read-access
zeripath Jul 9, 2022
dc477e7
Merge branch 'main' into store-team-read-access
6543 Jul 9, 2022
d7af1e3
Merge branch 'main' into store-team-read-access
Jul 10, 2022
1ddf8bb
Merge branch 'main' into store-team-read-access
6543 Jul 10, 2022
34b7519
Merge branch 'main' into store-team-read-access
6543 Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion models/perm/access/access.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,13 @@ func updateUserAccess(accessMap map[int64]*userAccess, user *user_model.User, mo
// FIXME: do cross-comparison so reduce deletions and additions to the minimum?
func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap map[int64]*userAccess) (err error) {
minMode := perm.AccessModeRead
if !repo.IsPrivate {
if err := repo.GetOwner(ctx); err != nil {
return fmt.Errorf("GetOwner: %v", err)
}

// If the repo isn't private and isn't owned by a organization,
// increase the minMode to Write.
if !repo.IsPrivate && !repo.Owner.IsOrganization() {
minMode = perm.AccessModeWrite
}

Expand Down