Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry SDK Crash Detection POC #49928

Closed
wants to merge 51 commits into from
Closed

Commits on Feb 7, 2023

  1. test: Fix test discovery by adding missing init.py

    Running test_discover.py with the test explorer in VSCode failed with an
    import file mismatch. This is fixed now by adding a missing __init__.py
    file to tests/sentry/data_export/processors.
    philipphofmann committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8f39673 View commit details
    Browse the repository at this point in the history
  2. backup

    philipphofmann committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    48cd13a View commit details
    Browse the repository at this point in the history
  3. backup

    philipphofmann committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    beb3c77 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Configuration menu
    Copy the full SHA
    9cdf838 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef31472 View commit details
    Browse the repository at this point in the history
  3. Rename to Cocoa

    philipphofmann committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    3b6bf5c View commit details
    Browse the repository at this point in the history
  4. Add events

    philipphofmann committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    9cc03e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. strip frames

    philipphofmann committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    fe89218 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db8f089 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0592d1c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. use mock

    philipphofmann committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8eda480 View commit details
    Browse the repository at this point in the history
  2. Use mocks

    philipphofmann committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    27482bd View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Configuration menu
    Copy the full SHA
    590718f View commit details
    Browse the repository at this point in the history
  2. givenCrashDetector

    philipphofmann committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ece3894 View commit details
    Browse the repository at this point in the history
  3. rename to event

    philipphofmann committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    53a4801 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7f859e3 View commit details
    Browse the repository at this point in the history
  5. add event stripper

    philipphofmann committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    83a578d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    fc1d72e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be86e37 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Configuration menu
    Copy the full SHA
    d842a57 View commit details
    Browse the repository at this point in the history
  2. add base class

    philipphofmann committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4216b94 View commit details
    Browse the repository at this point in the history
  3. split up into files

    philipphofmann committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b9e95eb View commit details
    Browse the repository at this point in the history
  4. fix tests

    philipphofmann committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    a793793 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    46dbf5d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0e29e2e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Configuration menu
    Copy the full SHA
    8a36861 View commit details
    Browse the repository at this point in the history
  2. Only keep in stack trace referenced debug images (#46494)

    Remove the debug images not referenced in the stack trace so the debug
    images don't contain customer data.
    
    Fixes GH-46174
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    philipphofmann and jjbayer authored Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b0a6ac3 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Configuration menu
    Copy the full SHA
    c3ddb38 View commit details
    Browse the repository at this point in the history
  2. Avoid infinite processing loop (#46578)

    Detect when an event has the context `sdk_crash_detection`, and skip
    crash monitoring in that case.
    
    Fixes GH-46173
    philipphofmann authored Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3b8c023 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. add __init__.py file

    philipphofmann committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e4d3300 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Configuration menu
    Copy the full SHA
    eea92f2 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    30d10c6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    ec5055f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    2958db6 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    5744b75 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    087e2c1 View commit details
    Browse the repository at this point in the history
  2. feat(sdk-crash-detection): Call code in post processing (#49170)

    Call SDK crash detection code in post-processing. I had to adapt the
    code a bit, cause I tested it with a dictionary instead of a stored
    event. I adapted the tests to use the same approach as the
    post-processing tests. The logic of the tests didn't change. I
    refactored all of them to work with stored events.
    
    Fixes GH-46175
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    philipphofmann and jjbayer authored May 30, 2023
    Configuration menu
    Copy the full SHA
    ed415e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Configuration menu
    Copy the full SHA
    95d93cc View commit details
    Browse the repository at this point in the history
  2. feat(sdk-crash-detection): Add feature flag (#49528)

    Add a feature flag for SDK Crash Detection #44342.
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    philipphofmann and jjbayer authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    90b1967 View commit details
    Browse the repository at this point in the history
  3. feat(sdk-crash-detection): Store event to dedicated project (#49593)

    Stores the detected SDK crash event to a configurable Sentry project.
    
    This PR is based on #49528.
    
    Fixes GH-46177
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    philipphofmann and jjbayer authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    082ddda View commit details
    Browse the repository at this point in the history
  4. fix(sdk-crash-detection): Reverse frame order (#49746)

    The stack trace frames are ordered from caller to callee, or oldest to
    youngest. Therefore, we must reverse the frame order when iterating
    over the frames to detect an SDK crash.
    
    This PR is based on #49593.
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io>
    3 people authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    cf3d1fc View commit details
    Browse the repository at this point in the history
  5. chore(sdk-crash-detection): Add to mypy.ini (#50284)

    Add src/sentry/utils/sdk_crashes to mypy.ini.
    
    Fixes GH-49938
    philipphofmann authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9870f03 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    a2c982d View commit details
    Browse the repository at this point in the history
  2. Remove empty inits

    philipphofmann committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    af352dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    629e2eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    35e2b0e View commit details
    Browse the repository at this point in the history
  5. feat(sdk-crash-detection): Event data allowlist (#50400)

    Specify an allowlist for the event data to ensure only keeping essential
    data doesn't contain PII.
    
    Fixes GH-49935
    
    This PR is based on #49928.
    
    Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
    Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
    3 people authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    045a9f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bf72f45 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e1785ff View commit details
    Browse the repository at this point in the history
  8. fix post process tests

    philipphofmann committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c710f36 View commit details
    Browse the repository at this point in the history
  9. fix type issues

    philipphofmann committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ea6b6dc View commit details
    Browse the repository at this point in the history