Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK Crash Detection to mypy.ini #49938

Closed
Tracked by #49749
philipphofmann opened this issue May 30, 2023 · 1 comment
Closed
Tracked by #49749

Add SDK Crash Detection to mypy.ini #49938

philipphofmann opened this issue May 30, 2023 · 1 comment
Assignees
@philipphofmann
Labels
Scope: Backend Automatically applied to PRs that change backend components

Comments

@philipphofmann
Copy link
Member

philipphofmann commented May 30, 2023 •
edited
Loading

Enforce the correctness of type hints by adding src/sentry/utils/sdk_crashes to mypy.ini and run make backend-typing.

Pointed out in #49593 (comment).
@philipphofmann philipphofmann mentioned this issue May 30, 2023
Closed
@philipphofmann philipphofmann self-assigned this May 30, 2023
@philipphofmann philipphofmann added Scope: Backend Automatically applied to PRs that change backend components Status: Backlog labels May 30, 2023
@philipphofmann philipphofmann mentioned this issue May 30, 2023
Merged
philipphofmann added a commit that referenced this issue Jun 5, 2023
@philipphofmann
chore(sdk-crash-detection): Add to mypy.ini
3da38db 
Add src/sentry/utils/sdk_crashes to mypy.ini.

Fixes GH-49938
@philipphofmann philipphofmann mentioned this issue Jun 5, 2023
Merged
philipphofmann added a commit that referenced this issue Jun 5, 2023
@philipphofmann
chore(sdk-crash-detection): Add to mypy.ini (#50284)
9870f03 
Add src/sentry/utils/sdk_crashes to mypy.ini.

Fixes GH-49938
@philipphofmann
Copy link
Member Author

Fixed with GH-50284

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@philipphofmann philipphofmann

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipphofmann