Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-crash-detection): Store event to dedicated project #49593

Merged
merged 48 commits into from
Jun 5, 2023

Conversation

philipphofmann
Copy link
Member

Stores the detected SDK crash event to a configurable Sentry project.

This PR is based on #49528.

Fixes GH-46177

philipphofmann and others added 30 commits April 3, 2023 11:30
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
@philipphofmann philipphofmann removed request for a team and AniketDas-Tekky June 5, 2023 07:32
@philipphofmann
Copy link
Member Author

I think due to a merge/rebase more people were assigned to review your PR :)

Not again. This is so annoying 🙈. Sorry about that.

@philipphofmann philipphofmann removed the request for review from a team June 5, 2023 07:33
@philipphofmann philipphofmann merged commit 082ddda into feat/sdk-crash-monitoring Jun 5, 2023
@philipphofmann philipphofmann deleted the feat/sdk-crash-save-event branch June 5, 2023 07:35
philipphofmann added a commit that referenced this pull request Jun 5, 2023
The stack trace frames are ordered from caller to callee, or oldest to
youngest. Therefore, we must reverse the frame order when iterating
over the frames to detect an SDK crash.

This PR is based on #49593.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants