-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-crash-detection): Store event to dedicated project #49593
Merged
philipphofmann
merged 48 commits into
feat/sdk-crash-monitoring
from
feat/sdk-crash-save-event
Jun 5, 2023
Merged
feat(sdk-crash-detection): Store event to dedicated project #49593
philipphofmann
merged 48 commits into
feat/sdk-crash-monitoring
from
feat/sdk-crash-save-event
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Not again. This is so annoying 🙈. Sorry about that. |
philipphofmann
added a commit
that referenced
this pull request
Jun 5, 2023
The stack trace frames are ordered from caller to callee, or oldest to youngest. Therefore, we must reverse the frame order when iterating over the frames to detect an SDK crash. This PR is based on #49593. Co-authored-by: Joris Bayer <joris.bayer@sentry.io> Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io>
This was referenced Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Scope: Frontend
Automatically applied to PRs that change frontend components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the detected SDK crash event to a configurable Sentry project.
This PR is based on #49528.
Fixes GH-46177