feat(sdk-crash-detection): Call code in post processing

[philipphofmann]

If you are not @getsentry/ingest you can skip this PR.

Merging master into feature branches accidentally requested a review from almost all teams at Sentry. I'm sorry about this.

PR Details

Call SDK crash detection code in post-processing. I had to adapt the code a bit, cause I tested it with a dictionary instead of a stored event. I adapted the tests to use the same approach as the post-processing tests. The logic of the tests didn't change. I refactored all of them to work with stored events.

The next step is to store the SDK crash event to a specific sentry project with #46177

I wasn't able to get parameterized tests working with test mixin approach. Does anybody know if that's possible?

Fixes GH-46175

[philipphofmann]

Hey, @getsentry/ingest, I would love to get a review on this PR, please 😃 .

[jjbayer]

I wasn't able to get parameterized tests working with test mixin approach. Does anybody know if that's possible?

pytest.mark.parametrize does not work in combination with unittest.TestCase, unfortunately: pytest-dev/pytest#541

Why are you moving from standalone (pytest) functions to class-based tests, if I may ask?

[philipphofmann]

Why are you moving from standalone (pytest) functions to class-based tests, if I may ask?

So I can apply the same approach for creating an event in test_post_process. I didn't manage to use the same approach with functions, @jjbayer.

[jjbayer]

Why are you moving from standalone (pytest) functions to class-based tests, if I may ask?

So I can apply the same approach for creating an event in test_post_process. I didn't manage to use the same approach with functions, @jjbayer.

Yeah so AFAIK you have to chose between using either @pytest.mark.parametrize or class-based testing with manual parameterization, whichever you prefer.

[asottile-sentry]

Why are you moving from standalone (pytest) functions to class-based tests, if I may ask?

So I can apply the same approach for creating an event in test_post_process. I didn't manage to use the same approach with functions, @jjbayer.

Yeah so AFAIK you have to chose between using either @pytest.mark.parametrize or class-based testing with manual parameterization, whichever you prefer.

of note, TestCase and class based tests are soft deprecated -- please try and write function tests moving forward (pytest has already begun to remove / unsupport functionality there over time -- the compat layer is only meant as a migration helper)

[philipphofmann]

Thanks for pointing that out, @asottile-sentry. I created an issue to change the tests to function tests #50061.