Update Camera Intrinsics in camera_info topic #265
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
This is a copy of #256 by @deepanshubansal01 with the merge conflicts and signoff errors resolved. The original PR was approved.
Fixes gazebosim/gz-sim#705
Summary
This PR solves the camera intrinsics not being reflected properly in
/camera_info
topic when the<intrinsics>
tag is not provided. The PR uses theCameraIntrinsicMatrix()
fromgz-rendering
package to get the camera intrinsics and update the sdf DOM object and/camera_info
topic.Depends on
gazebosim/gz-rendering#700
Checklist
codecheck
passed (See contributing)🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸